From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:34028) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SQ6zx-000224-CL for qemu-devel@nongnu.org; Thu, 03 May 2012 21:07:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SQ6zv-00050u-IY for qemu-devel@nongnu.org; Thu, 03 May 2012 21:07:52 -0400 Received: from cantor2.suse.de ([195.135.220.15]:35361 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SQ6zv-00050j-9A for qemu-devel@nongnu.org; Thu, 03 May 2012 21:07:51 -0400 Message-ID: <4FA32BE2.1030401@suse.de> Date: Fri, 04 May 2012 03:07:46 +0200 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= MIME-Version: 1.0 References: <4FA325BD.40201@codemonkey.ws> In-Reply-To: <4FA325BD.40201@codemonkey.ws> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] unreviewed commits (was: Re: Restore consistent formatting) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: malc Cc: Peter Maydell , Alexander Graf , qemu-devel@nongnu.org, Anthony Liguori , Markus Armbruster Am 04.05.2012 02:41, schrieb Anthony Liguori: > On 05/03/2012 02:58 PM, Peter Maydell wrote: >> On 9 February 2012 13:46, Anthony Liguori wrot= e: >>> On 02/09/2012 03:48 AM, Markus Armbruster wrote: >>>> You buried the one truly important sentence, let me dig it out for y= ou: >>>> >>>> *** Patches should always go to the mailing list *** >>>> >>>> Exceptions need justification. Responsible handling embargoed secur= ity >>>> issues may qualify. Style fixes certainly not. >>> >>> 100% agreed. >> >> I don't see anything in the mailing list archives corresponding >> to commits f05ae537, f6af014e. >> >> No unreviewed patches should go double when we're in hardfreeze! >=20 > These patches are admittedly trivial but it is important to stress the > point that all patches need to go on the mailing list before being > committed. >=20 > It's an important part of keeping the development process inclusive. I > don't think it's reasonable to ask for an Acked-by on something as > simple as indentation changes but at the same time, there's no reason > not to just post patches. The second patch is far from trivial! It unneededly breaks the build on ppc hosts (during the Hard Freeze!), so that I can no longer compile-test my patch series against PowerKVM. Please revert immediately and either use a warning or a runtime abort. And please use a proper commit message indicating that it affects "tcg/pp= c". Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC= rnberg