From: Christian Borntraeger <borntraeger@de.ibm.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Anthony Liguori <aliguori@us.ibm.com>,
agraf@suse.de, QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] Fix size checking in load_image_targphys to accept max_size > INT_MAX
Date: Fri, 04 May 2012 16:05:15 +0200 [thread overview]
Message-ID: <4FA3E21B.5030303@de.ibm.com> (raw)
In-Reply-To: <CAFEAcA_w9AbTB_93ehMMRb9UDKiM3UEToTQgLHX6cRQsbA-juA@mail.gmail.com>
>> Since load_image_targphys is declared as taking an int for max_sz, this will
>> fail for ram sizes > INT_MAX.
>> Lets change the max_sz parameter to a uint64_t.
>>
>> Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
>
> A patch equivalent to this has already been submitted:
> http://patchwork.ozlabs.org/patch/146165/
> We should be applying that one, it has already been reviewed.
Right.
>
> Anthony?
AFAIK Anthony is on holiday. It would be good, if we could have that before 1.1, so shall
we wait or are there other maintainers willing to accept that patch?
Christian
next prev parent reply other threads:[~2012-05-04 14:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-03 13:36 [Qemu-devel] S390: file size checking in load_image_targphys and certain ram sizes Christian Borntraeger
2012-05-03 13:51 ` Alexander Graf
2012-05-03 14:27 ` [Qemu-devel] [PATCH] Fix size checking in load_image_targphys to accept max_size > INT_MAX Christian Borntraeger
2012-05-03 14:33 ` Peter Maydell
2012-05-04 14:05 ` Christian Borntraeger [this message]
2012-05-09 10:42 ` Christian Borntraeger
2012-05-16 10:29 ` Christian Borntraeger
2012-05-18 0:18 ` Alexander Graf
2012-05-18 0:26 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FA3E21B.5030303@de.ibm.com \
--to=borntraeger@de.ibm.com \
--cc=agraf@suse.de \
--cc=aliguori@us.ibm.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).