From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:41512) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SQLAJ-0000NP-Iy for qemu-devel@nongnu.org; Fri, 04 May 2012 12:15:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SQLAD-0007fW-6D for qemu-devel@nongnu.org; Fri, 04 May 2012 12:15:31 -0400 Received: from mail-pb0-f45.google.com ([209.85.160.45]:60056) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SQLAC-0007fL-Tc for qemu-devel@nongnu.org; Fri, 04 May 2012 12:15:25 -0400 Received: by pbbro12 with SMTP id ro12so5128630pbb.4 for ; Fri, 04 May 2012 09:15:22 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <4FA40091.7020206@redhat.com> Date: Fri, 04 May 2012 18:15:13 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1335958273-769-1-git-send-email-pbonzini@redhat.com> In-Reply-To: <1335958273-769-1-git-send-email-pbonzini@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 00/21] qbus QOM conversion, rebased on top of my patches List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, aliguori@us.ibm.com, qemu-devel@nongnu.org, afaerber@suse.de, liwp@linux.vnet.ibm.com Il 02/05/2012 13:30, Paolo Bonzini ha scritto: > Here is Anthony's qbus conversion, with the qdev_add_properties changes > replaced by my bus property changes. > > I left out the removal of bus methods; I'm not sure I agree with all of > them (though I may just give up :)) and anyway they can be left to 1.2. > > Following Andreas's remark, I moved all TYPE_* definitions for buses > to the same file that defines the struct, and added typecasting macros. > > I'm still a bit weary of putting this in this late, but I'll defer to > others on this too. > > Anthony Liguori (6): > qdev: fix adding of ptr properties > qdev: use wrapper for qdev_get_path > qdev: convert busses to QEMU Object Model > qdev: connect busses with their parent devices > qbus: make child devices links > qbus: initialize in standard way > > Paolo Bonzini (15): > qom: documentation addition > qom: add object_class_get_parent > qom: add class_base_init > qom: make Object a type > qom: assert that public types have a non-NULL parent field > qdev: push "type" property up to Object > qdev: fix -device foo,? > qdev: use object_property_print in info qtree > qdev: move bus properties to a separate global > qdev: do not propagate properties to subclasses > qdev: move bus properties to abstract superclasses > pc: add back PCI.rombar compat property > qdev: clean up global properties > qdev: remove qdev_prop_set_defaults > qdev: move sysbus initialization to sysbus.c Guys, I'll let you decide what to do about this. If anyone wnts to pick up the reviews and resubmit in my place, that would be nice. In any case, patches 7-8 should be blockers for rc1. Paolo