From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:60276) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SQLOC-0004Qe-3g for qemu-devel@nongnu.org; Fri, 04 May 2012 12:29:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SQLO7-0005eQ-91 for qemu-devel@nongnu.org; Fri, 04 May 2012 12:29:51 -0400 Received: from mx1.redhat.com ([209.132.183.28]:52844) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SQLO7-0005bt-0v for qemu-devel@nongnu.org; Fri, 04 May 2012 12:29:47 -0400 Message-ID: <4FA403F6.4070506@redhat.com> Date: Fri, 04 May 2012 18:29:42 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1336121154-26517-1-git-send-email-pbonzini@redhat.com> <1336121154-26517-3-git-send-email-pbonzini@redhat.com> <4FA403BD.2050309@weilnetz.de> In-Reply-To: <4FA403BD.2050309@weilnetz.de> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 02/14] scsi: prevent data transfer overflow List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Weil Cc: qemu-devel@nongnu.org Il 04/05/2012 18:28, Stefan Weil ha scritto: >> >> - !(buf[0] == REQUEST_SENSE&& d->sense_is_ua))) { >> + if (cmd.xfer> INT32_MAX) { >> + req = scsi_req_alloc(&reqops_invalid_field, d, tag, lun, >> hba_private); > > WARNING: line over 80 characters > #54: FILE: hw/scsi-bus.c:533: > + req = scsi_req_alloc(&reqops_invalid_field, d, tag, lun, > hba_private); > > total: 0 errors, 1 warnings, 50 lines checked > > 0002-scsi-prevent-data-transfer-overflow.patch has style problems, > please review. If any of these errors > are false positives report them to the maintainer, see > CHECKPATCH in MAINTAINERS. It's a warning for a reason... Paolo