From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:49008) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SQLUg-0001JO-8s for qemu-devel@nongnu.org; Fri, 04 May 2012 12:36:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SQLUe-0000EO-Hu for qemu-devel@nongnu.org; Fri, 04 May 2012 12:36:33 -0400 Received: from mail-pb0-f45.google.com ([209.85.160.45]:54117) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SQLUe-0000EB-93 for qemu-devel@nongnu.org; Fri, 04 May 2012 12:36:32 -0400 Received: by pbbro12 with SMTP id ro12so5158545pbb.4 for ; Fri, 04 May 2012 09:36:30 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <4FA40587.6030006@redhat.com> Date: Fri, 04 May 2012 18:36:23 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1336121154-26517-1-git-send-email-pbonzini@redhat.com> <1336121154-26517-7-git-send-email-pbonzini@redhat.com> <4FA40420.1070902@weilnetz.de> In-Reply-To: <4FA40420.1070902@weilnetz.de> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 06/14] scsi: change "removable" field to host many features List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Weil Cc: qemu-devel@nongnu.org Il 04/05/2012 18:30, Stefan Weil ha scritto: >> >> +#define SCSI_DISK_F_REMOVABLE 0 >> + > > ERROR: code indent should never use tabs > #23: FILE: hw/scsi-disk.c:64: > +#define SCSI_DISK_F_REMOVABLE^I0$ > > total: 1 errors, 0 warnings, 74 lines checked Not code indent. $ git grep $'^#.*define.*\t' -- \*.c |wc -l 3244 Paolo