From: Paolo Bonzini <pbonzini@redhat.com>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: mdroth@linux.vnet.ibm.com, qemu-devel@nongnu.org, kraxel@redhat.com
Subject: Re: [Qemu-devel] [PATCH 3/4] runstate: introduce suspended state
Date: Fri, 04 May 2012 18:39:06 +0200 [thread overview]
Message-ID: <4FA4062A.8060207@redhat.com> (raw)
In-Reply-To: <1336143722-15050-4-git-send-email-lcapitulino@redhat.com>
Il 04/05/2012 17:02, Luiz Capitulino ha scritto:
> diff --git a/qapi-schema.json b/qapi-schema.json
> index 0166ec2..4dbcb26 100644
> --- a/qapi-schema.json
> +++ b/qapi-schema.json
> @@ -116,12 +116,14 @@
> #
> # @shutdown: guest is shut down (and -no-shutdown is in use)
> #
> +# @suspended: guest is suspended (ACPI S3)
> +#
> # @watchdog: the watchdog action is configured to pause and has been triggered
> ##
> { 'enum': 'RunState',
> 'data': [ 'debug', 'inmigrate', 'internal-error', 'io-error', 'paused',
> 'postmigrate', 'prelaunch', 'finish-migrate', 'restore-vm',
> - 'running', 'save-vm', 'shutdown', 'watchdog' ] }
> + 'running', 'save-vm', 'shutdown', 'suspended', 'watchdog' ] }
>
This breaks QAPI ABI.
Not really a breaker for this series, but it shows how we are not yet
ready to keep a stable ABI (as opposed to API), and thus any
restrictions on adding optional arguments to commands are premature.
(And IMO wrong, there are plenty of ways to have versioned symbols in C
without breaking the ABI---not talking about ELF symbol versioning).
Paolo
next prev parent reply other threads:[~2012-05-04 16:39 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-04 15:01 [Qemu-devel] [PATCH v2 0/4]: runstate: introduce 'suspended' state Luiz Capitulino
2012-05-04 15:01 ` [Qemu-devel] [PATCH 1/4] wakeup on migration Luiz Capitulino
2012-05-04 15:02 ` [Qemu-devel] [PATCH 2/4] qapi-schema.json: fix RunState enums alphabetical order Luiz Capitulino
2012-05-04 15:02 ` [Qemu-devel] [PATCH 3/4] runstate: introduce suspended state Luiz Capitulino
2012-05-04 16:39 ` Paolo Bonzini [this message]
2012-05-04 16:50 ` Luiz Capitulino
2012-05-04 17:07 ` Eric Blake
2012-05-04 17:13 ` Luiz Capitulino
2012-05-05 7:55 ` Paolo Bonzini
2012-05-07 2:23 ` Luiz Capitulino
2012-05-04 15:02 ` [Qemu-devel] [PATCH 4/4] vl: prop is_suspended variable Luiz Capitulino
2012-05-07 7:02 ` Markus Armbruster
2012-05-07 11:32 ` Luiz Capitulino
-- strict thread matches above, loose matches on Subject: below --
2012-05-07 13:56 [Qemu-devel] [PATCH v3 0/4]: runstate: introduce 'suspended' state Luiz Capitulino
2012-05-07 13:56 ` [Qemu-devel] [PATCH 3/4] runstate: introduce suspended state Luiz Capitulino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FA4062A.8060207@redhat.com \
--to=pbonzini@redhat.com \
--cc=kraxel@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).