From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:49553)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1SQLXI-0002Fm-O3
	for qemu-devel@nongnu.org; Fri, 04 May 2012 12:39:17 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1SQLXG-0001E2-TX
	for qemu-devel@nongnu.org; Fri, 04 May 2012 12:39:16 -0400
Received: from mail-pz0-f45.google.com ([209.85.210.45]:64203)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1SQLXG-0001CS-JR
	for qemu-devel@nongnu.org; Fri, 04 May 2012 12:39:14 -0400
Received: by dadv2 with SMTP id v2so4272345dad.4
	for <qemu-devel@nongnu.org>; Fri, 04 May 2012 09:39:12 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <4FA4062A.8060207@redhat.com>
Date: Fri, 04 May 2012 18:39:06 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1336143722-15050-1-git-send-email-lcapitulino@redhat.com>
	<1336143722-15050-4-git-send-email-lcapitulino@redhat.com>
In-Reply-To: <1336143722-15050-4-git-send-email-lcapitulino@redhat.com>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 3/4] runstate: introduce suspended state
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: mdroth@linux.vnet.ibm.com, qemu-devel@nongnu.org, kraxel@redhat.com

Il 04/05/2012 17:02, Luiz Capitulino ha scritto:
> diff --git a/qapi-schema.json b/qapi-schema.json
> index 0166ec2..4dbcb26 100644
> --- a/qapi-schema.json
> +++ b/qapi-schema.json
> @@ -116,12 +116,14 @@
>  #
>  # @shutdown: guest is shut down (and -no-shutdown is in use)
>  #
> +# @suspended: guest is suspended (ACPI S3)
> +#
>  # @watchdog: the watchdog action is configured to pause and has been triggered
>  ##
>  { 'enum': 'RunState',
>    'data': [ 'debug', 'inmigrate', 'internal-error', 'io-error', 'paused',
>              'postmigrate', 'prelaunch', 'finish-migrate', 'restore-vm',
> -            'running', 'save-vm', 'shutdown', 'watchdog' ] }
> +            'running', 'save-vm', 'shutdown', 'suspended', 'watchdog' ] }
>  

This breaks QAPI ABI.

Not really a breaker for this series, but it shows how we are not yet
ready to keep a stable ABI (as opposed to API), and thus any
restrictions on adding optional arguments to commands are premature.
(And IMO wrong, there are plenty of ways to have versioned symbols in C
without breaking the ABI---not talking about ELF symbol versioning).

Paolo