From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:57374) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SQLhR-0004T9-Q2 for qemu-devel@nongnu.org; Fri, 04 May 2012 12:49:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SQLhQ-0005hi-1Y for qemu-devel@nongnu.org; Fri, 04 May 2012 12:49:45 -0400 Received: from cantor2.suse.de ([195.135.220.15]:45890 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SQLhP-0005hV-RT for qemu-devel@nongnu.org; Fri, 04 May 2012 12:49:43 -0400 Message-ID: <4FA408A6.7080604@suse.de> Date: Fri, 04 May 2012 18:49:42 +0200 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1336121154-26517-1-git-send-email-pbonzini@redhat.com> <1336121154-26517-7-git-send-email-pbonzini@redhat.com> <4FA40420.1070902@weilnetz.de> <4FA40587.6030006@redhat.com> In-Reply-To: <4FA40587.6030006@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 06/14] scsi: change "removable" field to host many features List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: Stefan Weil , qemu-devel@nongnu.org Am 04.05.2012 18:36, schrieb Paolo Bonzini: > Il 04/05/2012 18:30, Stefan Weil ha scritto: >>> >>> +#define SCSI_DISK_F_REMOVABLE 0 >>> + >> >> ERROR: code indent should never use tabs >> #23: FILE: hw/scsi-disk.c:64: >> +#define SCSI_DISK_F_REMOVABLE^I0$ >> >> total: 1 errors, 0 warnings, 74 lines checked >=20 > Not code indent. >=20 > $ git grep $'^#.*define.*\t' -- \*.c |wc -l > 3244 So? We add missing braces on the lines we touch as well. On the lines I'm touching in my upcoming series I've thus space-converted such tabs. Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg