From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:42874) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SQLyY-00019t-Vx for qemu-devel@nongnu.org; Fri, 04 May 2012 13:07:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SQLyX-00049W-2t for qemu-devel@nongnu.org; Fri, 04 May 2012 13:07:26 -0400 Received: from mx1.redhat.com ([209.132.183.28]:43978) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SQLyW-00049O-Qg for qemu-devel@nongnu.org; Fri, 04 May 2012 13:07:24 -0400 Message-ID: <4FA40CB7.6060804@redhat.com> Date: Fri, 04 May 2012 11:07:03 -0600 From: Eric Blake MIME-Version: 1.0 References: <1336143722-15050-1-git-send-email-lcapitulino@redhat.com> <1336143722-15050-4-git-send-email-lcapitulino@redhat.com> <4FA4062A.8060207@redhat.com> <20120504135054.698444ec@doriath.home> In-Reply-To: <20120504135054.698444ec@doriath.home> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enig7FE5548E045B1CA0E9086284" Subject: Re: [Qemu-devel] [PATCH 3/4] runstate: introduce suspended state List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino Cc: Paolo Bonzini , kraxel@redhat.com, mdroth@linux.vnet.ibm.com, qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig7FE5548E045B1CA0E9086284 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 05/04/2012 10:50 AM, Luiz Capitulino wrote: > On Fri, 04 May 2012 18:39:06 +0200 > Paolo Bonzini wrote: >=20 >> Il 04/05/2012 17:02, Luiz Capitulino ha scritto: >>> diff --git a/qapi-schema.json b/qapi-schema.json >>> index 0166ec2..4dbcb26 100644 >>> --- a/qapi-schema.json >>> +++ b/qapi-schema.json >>> @@ -116,12 +116,14 @@ >>> # >>> # @shutdown: guest is shut down (and -no-shutdown is in use) >>> # >>> +# @suspended: guest is suspended (ACPI S3) >>> +# >>> # @watchdog: the watchdog action is configured to pause and has been= triggered >>> ## >>> { 'enum': 'RunState', >>> 'data': [ 'debug', 'inmigrate', 'internal-error', 'io-error', 'pau= sed', >>> 'postmigrate', 'prelaunch', 'finish-migrate', 'restore-v= m', >>> - 'running', 'save-vm', 'shutdown', 'watchdog' ] } >>> + 'running', 'save-vm', 'shutdown', 'suspended', 'watchdog= ' ] } >>> =20 >> >> This breaks QAPI ABI. >> >> Not really a breaker for this series, but it shows how we are not yet >> ready to keep a stable ABI (as opposed to API), and thus any >=20 > Having to add a new enum every time a new value is needed is going to b= e fun. I think Paolo's point was that new values should be added at the end of the list. Your patch, as written, changes 'watchdog' from 13th to 14th; what you should have done is left 'watchdog' at 13th and made 'suspended' be 14th. --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enig7FE5548E045B1CA0E9086284 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBCAAGBQJPpAy3AAoJEKeha0olJ0NqraAH+wQf0IkH6apOXQ5Br6rMO8bB KuAAT+TZTjkw6IWje1CLgG/DRVgSuuV1TJPnZnv/PKxPWTDZb8xuICaqWt4ZBrJe /FbXkL4dzXchLqgoW7k65qK4KNQcm1yEcvuR6eWXGnF7Zdwl+dScfKJcUaY2OXWd z8r4T02T/GFWBVX0bBAMgcJdNEH9Ces9nW21DiUOnU670T8MJfT6OvhmCghtgZoe FsCXKUYPzxgB5dg4HS3OiodQDS54Ppy9USSck6SvellSzgnb0dvA2stDNosZ4FCw RlRs7Pvy+2aflqZVhWmJVaUogSagUHd/W8Qf9OtRn+dPOTsXR29seOJ/saAuiVw= =L2Hg -----END PGP SIGNATURE----- --------------enig7FE5548E045B1CA0E9086284--