From: Paolo Bonzini <pbonzini@redhat.com>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: qemu-devel@nongnu.org, Eric Blake <eblake@redhat.com>,
kraxel@redhat.com, mdroth@linux.vnet.ibm.com
Subject: Re: [Qemu-devel] [PATCH 3/4] runstate: introduce suspended state
Date: Sat, 05 May 2012 09:55:35 +0200 [thread overview]
Message-ID: <4FA4DCF7.1050301@redhat.com> (raw)
In-Reply-To: <20120504141350.3337d5d6@doriath.home>
Il 04/05/2012 19:13, Luiz Capitulino ha scritto:
>>>> > >> This breaks QAPI ABI.
>>>> > >>
>>>> > >> Not really a breaker for this series, but it shows how we are not yet
>>>> > >> ready to keep a stable ABI (as opposed to API), and thus any
>>> > >
>>> > > Having to add a new enum every time a new value is needed is going to be fun.
>> >
>> > I think Paolo's point was that new values should be added at the end of
>> > the list. Your patch, as written, changes 'watchdog' from 13th to 14th;
>> > what you should have done is left 'watchdog' at 13th and made
>> > 'suspended' be 14th.
>
> We don't have a stable QAPI ABI today, and if I'm not missing the point
> here he's advocating against it.
Yes, but Eric's solution would be fine.
> I don't think this series need any changes in that regard.
I agree.
Paolo
next prev parent reply other threads:[~2012-05-05 7:55 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-04 15:01 [Qemu-devel] [PATCH v2 0/4]: runstate: introduce 'suspended' state Luiz Capitulino
2012-05-04 15:01 ` [Qemu-devel] [PATCH 1/4] wakeup on migration Luiz Capitulino
2012-05-04 15:02 ` [Qemu-devel] [PATCH 2/4] qapi-schema.json: fix RunState enums alphabetical order Luiz Capitulino
2012-05-04 15:02 ` [Qemu-devel] [PATCH 3/4] runstate: introduce suspended state Luiz Capitulino
2012-05-04 16:39 ` Paolo Bonzini
2012-05-04 16:50 ` Luiz Capitulino
2012-05-04 17:07 ` Eric Blake
2012-05-04 17:13 ` Luiz Capitulino
2012-05-05 7:55 ` Paolo Bonzini [this message]
2012-05-07 2:23 ` Luiz Capitulino
2012-05-04 15:02 ` [Qemu-devel] [PATCH 4/4] vl: prop is_suspended variable Luiz Capitulino
2012-05-07 7:02 ` Markus Armbruster
2012-05-07 11:32 ` Luiz Capitulino
-- strict thread matches above, loose matches on Subject: below --
2012-05-07 13:56 [Qemu-devel] [PATCH v3 0/4]: runstate: introduce 'suspended' state Luiz Capitulino
2012-05-07 13:56 ` [Qemu-devel] [PATCH 3/4] runstate: introduce suspended state Luiz Capitulino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FA4DCF7.1050301@redhat.com \
--to=pbonzini@redhat.com \
--cc=eblake@redhat.com \
--cc=kraxel@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).