From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:58642) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SQZqA-00078b-24 for qemu-devel@nongnu.org; Sat, 05 May 2012 03:55:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SQZq8-0002dk-8Z for qemu-devel@nongnu.org; Sat, 05 May 2012 03:55:41 -0400 Received: from mail-wi0-f175.google.com ([209.85.212.175]:52776) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SQZq8-0002dP-06 for qemu-devel@nongnu.org; Sat, 05 May 2012 03:55:40 -0400 Received: by wibhn6 with SMTP id hn6so1826284wib.10 for ; Sat, 05 May 2012 00:55:38 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <4FA4DCF7.1050301@redhat.com> Date: Sat, 05 May 2012 09:55:35 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1336143722-15050-1-git-send-email-lcapitulino@redhat.com> <1336143722-15050-4-git-send-email-lcapitulino@redhat.com> <4FA4062A.8060207@redhat.com> <20120504135054.698444ec@doriath.home> <4FA40CB7.6060804@redhat.com> <20120504141350.3337d5d6@doriath.home> In-Reply-To: <20120504141350.3337d5d6@doriath.home> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 3/4] runstate: introduce suspended state List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino Cc: qemu-devel@nongnu.org, Eric Blake , kraxel@redhat.com, mdroth@linux.vnet.ibm.com Il 04/05/2012 19:13, Luiz Capitulino ha scritto: >>>> > >> This breaks QAPI ABI. >>>> > >> >>>> > >> Not really a breaker for this series, but it shows how we are not yet >>>> > >> ready to keep a stable ABI (as opposed to API), and thus any >>> > > >>> > > Having to add a new enum every time a new value is needed is going to be fun. >> > >> > I think Paolo's point was that new values should be added at the end of >> > the list. Your patch, as written, changes 'watchdog' from 13th to 14th; >> > what you should have done is left 'watchdog' at 13th and made >> > 'suspended' be 14th. > > We don't have a stable QAPI ABI today, and if I'm not missing the point > here he's advocating against it. Yes, but Eric's solution would be fine. > I don't think this series need any changes in that regard. I agree. Paolo