From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:42486) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SR7gj-0007tb-Hb for qemu-devel@nongnu.org; Sun, 06 May 2012 16:04:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SR7gh-0008IP-Hu for qemu-devel@nongnu.org; Sun, 06 May 2012 16:04:12 -0400 Message-ID: <4FA6D92E.2000905@web.de> Date: Sun, 06 May 2012 22:03:58 +0200 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= MIME-Version: 1.0 References: <1336333113-773-1-git-send-email-andreas.faerber@web.de> In-Reply-To: <1336333113-773-1-git-send-email-andreas.faerber@web.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [RFC] tcg/ppc: Do not overwrite lower address word on Darwin and AIX List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: malc Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org Am 06.05.2012 21:38, schrieb Andreas Färber: > For targets where TARGET_LONG_BITS != 32, i.e. 64-bit guests, > addr_reg is moved to r4. For hosts with TCG_TARGET_CALL_ALIGN_ARGS Er, obviously I meant "without". :) /-F > either data_reg2 or data_reg or a masked version thereof would overwrite > r4. Place it in r5 instead, matching TCG_TARGET_CALL_ALIGN_ARGS hosts. > > This might explain crashes observed on Darwin/ppc but not on ppc64. > > Signed-off-by: Andreas Färber > --- > tcg/ppc/tcg-target.c | 4 ---- > 1 files changed, 0 insertions(+), 4 deletions(-) > > diff --git a/tcg/ppc/tcg-target.c b/tcg/ppc/tcg-target.c > index dc40716..4b85c89 100644 > --- a/tcg/ppc/tcg-target.c > +++ b/tcg/ppc/tcg-target.c > @@ -816,11 +816,7 @@ static void tcg_out_qemu_st (TCGContext *s, const TCGArg *args, int opc) > #else > tcg_out_mov (s, TCG_TYPE_I32, 3, addr_reg2); > tcg_out_mov (s, TCG_TYPE_I32, 4, addr_reg); > -#ifdef TCG_TARGET_CALL_ALIGN_ARGS > ir = 5; > -#else > - ir = 4; > -#endif > #endif > > switch (opc) {