Re: [Qemu-devel] [PATCH] fdc: simplify media change handling

[Kevin Wolf <kwolf@redhat.com>]

Am 05.05.2012 19:43, schrieb Hervé Poussineau:
> This also (partly) fixes IBM OS/2 Warp 4.0 floppy installation, where
> not all floppies have the same format (2x80x18 for the first ones,
> 2x80x23 for the next ones).
> 
> Signed-off-by: Hervé Poussineau <hpoussin@reactos.org>
> ---
> 
> This patch fixes a real use case, and I didn't notice any regression.
> However, as we are in bugfixes-only period, I let Kevin decide if it
> is worth to include (or not) this patch in QEMU 1.1.
> 
>  hw/fdc.c |   29 +++++++++++------------------
>  1 file changed, 11 insertions(+), 18 deletions(-)

I think this patch still doesn't get it entirely right (it would also
reset the bit if the head didn't actually move because it already was in
the right position, whereas real hardware wouldn't reset it there), but
it looks much better than what we have today and provided it passes my
testing I would like to include it in 1.1.

With which OSes did you already test it?

Kevin