From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:59647) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SRJBS-0006ep-8F for qemu-devel@nongnu.org; Mon, 07 May 2012 04:20:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SRJBP-0007tn-IR for qemu-devel@nongnu.org; Mon, 07 May 2012 04:20:41 -0400 Received: from mx1.redhat.com ([209.132.183.28]:44740) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SRJBP-0007tT-As for qemu-devel@nongnu.org; Mon, 07 May 2012 04:20:39 -0400 Message-ID: <4FA785D2.5020407@redhat.com> Date: Mon, 07 May 2012 10:20:34 +0200 From: Kevin Wolf MIME-Version: 1.0 References: <1336239809-3958-1-git-send-email-hpoussin@reactos.org> In-Reply-To: <1336239809-3958-1-git-send-email-hpoussin@reactos.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] fdc: simplify media change handling List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?SGVydsOpIFBvdXNzaW5lYXU=?= Cc: qemu-devel@nongnu.org Am 05.05.2012 19:43, schrieb Herv=C3=A9 Poussineau: > This also (partly) fixes IBM OS/2 Warp 4.0 floppy installation, where > not all floppies have the same format (2x80x18 for the first ones, > 2x80x23 for the next ones). >=20 > Signed-off-by: Herv=C3=A9 Poussineau > --- >=20 > This patch fixes a real use case, and I didn't notice any regression. > However, as we are in bugfixes-only period, I let Kevin decide if it > is worth to include (or not) this patch in QEMU 1.1. >=20 > hw/fdc.c | 29 +++++++++++------------------ > 1 file changed, 11 insertions(+), 18 deletions(-) I think this patch still doesn't get it entirely right (it would also reset the bit if the head didn't actually move because it already was in the right position, whereas real hardware wouldn't reset it there), but it looks much better than what we have today and provided it passes my testing I would like to include it in 1.1. With which OSes did you already test it? Kevin