From: Kevin Wolf <kwolf@redhat.com>
To: zwu.kernel@gmail.com
Cc: Zhi Yong Wu <wuzhy@linux.vnet.ibm.com>,
marcandre.lureau@gmail.com, qemu-devel@nongnu.org,
stefanha@linux.vnet.ibm.com
Subject: Re: [Qemu-devel] [PATCH 1/2] block: make bdrv_create adopt coroutine
Date: Mon, 07 May 2012 10:32:20 +0200 [thread overview]
Message-ID: <4FA78894.5080100@redhat.com> (raw)
In-Reply-To: <1336188532-28038-1-git-send-email-zwu.kernel@gmail.com>
Am 05.05.2012 05:28, schrieb zwu.kernel@gmail.com:
> From: Zhi Yong Wu <wuzhy@linux.vnet.ibm.com>
>
> Signed-off-by: Zhi Yong Wu <wuzhy@linux.vnet.ibm.com>
> ---
> block.c | 48 +++++++++++++++++++++++++++++++++++++++++++++++-
> 1 files changed, 47 insertions(+), 1 deletions(-)
What's this? A version 2 of half the patch series, with the implicit
assumption that I should take patch 2 from version 1? You should resend
the whole series, you should ensure proper email threading, and you
should include a v2 in the subject line (git format-patch
--subject-prefix="PATCH v2"). Your commit messages are lacking, too. I
have no idea _why_ you are making the change.
In short: Please read http://wiki.qemu.org/Contribute/SubmitAPatch once
again and be sure to follow its advices.
Kevin
next prev parent reply other threads:[~2012-05-07 8:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-05 3:28 [Qemu-devel] [PATCH 1/2] block: make bdrv_create adopt coroutine zwu.kernel
2012-05-07 8:32 ` Kevin Wolf [this message]
2012-05-07 8:39 ` Zhi Yong Wu
-- strict thread matches above, loose matches on Subject: below --
2012-05-05 3:13 zwu.kernel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FA78894.5080100@redhat.com \
--to=kwolf@redhat.com \
--cc=marcandre.lureau@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@linux.vnet.ibm.com \
--cc=wuzhy@linux.vnet.ibm.com \
--cc=zwu.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).