From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:52630) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SRR49-00044O-DF for qemu-devel@nongnu.org; Mon, 07 May 2012 12:45:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SRR47-00040W-RH for qemu-devel@nongnu.org; Mon, 07 May 2012 12:45:40 -0400 Message-ID: <4FA7FC30.9010604@adacore.com> Date: Mon, 07 May 2012 18:45:36 +0200 From: Fabien Chouteau MIME-Version: 1.0 References: <1336408881-3851-1-git-send-email-chouteau@adacore.com> <0FFF7458-DF56-4BD1-9D12-2DD5E57B9971@suse.de> In-Reply-To: <0FFF7458-DF56-4BD1-9D12-2DD5E57B9971@suse.de> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] ppcmas_tlb_check: Fix effective address comparison List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org On 05/07/2012 06:43 PM, Alexander Graf wrote: > > On 07.05.2012, at 18:41, Fabien Chouteau wrote: > >> Use size mask in both operands of effective address comparison. >> This is the expected as the size of EPN field in MAS2 depends on page >> size. >> >> Definition of EPN field from e500v2 RM: >> EPN Effective page number: Depending on page size, only the bits >> associated with a page boundary are valid. Bits that represent offsets >> within a page are ignored and should be cleared. >> >> There is a similar (but more complicated) definition in PowerISA V2.06. > > Would it make sense to do this at tlbwe time? That path is a bit less hot that the tlb check :). Why not, I'll check that tomorrow. Thanks, -- Fabien Chouteau