From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:33675) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SRTOR-0001fW-1W for qemu-devel@nongnu.org; Mon, 07 May 2012 15:14:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SRTOP-0001OL-4v for qemu-devel@nongnu.org; Mon, 07 May 2012 15:14:46 -0400 Received: from smtp1-g21.free.fr ([212.27.42.1]:48100) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SRTOO-0001Mp-Hg for qemu-devel@nongnu.org; Mon, 07 May 2012 15:14:45 -0400 Message-ID: <4FA81F1B.3080001@reactos.org> Date: Mon, 07 May 2012 21:14:35 +0200 From: =?UTF-8?B?SGVydsOpIFBvdXNzaW5lYXU=?= MIME-Version: 1.0 References: <1336239809-3958-1-git-send-email-hpoussin@reactos.org> <4FA785D2.5020407@redhat.com> In-Reply-To: <4FA785D2.5020407@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] fdc: simplify media change handling List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: qemu-devel@nongnu.org Kevin Wolf a =C3=A9crit : > Am 05.05.2012 19:43, schrieb Herv=C3=A9 Poussineau: >> This also (partly) fixes IBM OS/2 Warp 4.0 floppy installation, where >> not all floppies have the same format (2x80x18 for the first ones, >> 2x80x23 for the next ones). >> >> Signed-off-by: Herv=C3=A9 Poussineau >> --- >> >> This patch fixes a real use case, and I didn't notice any regression. >> However, as we are in bugfixes-only period, I let Kevin decide if it >> is worth to include (or not) this patch in QEMU 1.1. >> >> hw/fdc.c | 29 +++++++++++------------------ >> 1 file changed, 11 insertions(+), 18 deletions(-) >=20 > I think this patch still doesn't get it entirely right (it would also > reset the bit if the head didn't actually move because it already was i= n > the right position, whereas real hardware wouldn't reset it there), but > it looks much better than what we have today and provided it passes my > testing I would like to include it in 1.1. >=20 > With which OSes did you already test it? >=20 I specifically tested floppy change on MSDOS 6.22, Windows 98 SE and=20 OS/2 4.0. Herv=C3=A9