From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:34555) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SRcib-00046N-TY for qemu-devel@nongnu.org; Tue, 08 May 2012 01:12:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SRcia-0006bk-1x for qemu-devel@nongnu.org; Tue, 08 May 2012 01:12:13 -0400 Received: from e28smtp05.in.ibm.com ([122.248.162.5]:33474) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SRciR-0006ZM-3w for qemu-devel@nongnu.org; Tue, 08 May 2012 01:12:11 -0400 Received: from /spool/local by e28smtp05.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 8 May 2012 10:41:41 +0530 Received: from d28av03.in.ibm.com (d28av03.in.ibm.com [9.184.220.65]) by d28relay05.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q485BcAK7209386 for ; Tue, 8 May 2012 10:41:39 +0530 Received: from d28av03.in.ibm.com (loopback [127.0.0.1]) by d28av03.in.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q48AerFU009828 for ; Tue, 8 May 2012 20:40:53 +1000 Message-ID: <4FA8AB08.5070505@linux.vnet.ibm.com> Date: Tue, 08 May 2012 10:41:36 +0530 From: Harsh Bora MIME-Version: 1.0 References: <1336067796-5730-1-git-send-email-harsh@linux.vnet.ibm.com> <1336067796-5730-2-git-send-email-harsh@linux.vnet.ibm.com> <87vck8xfvy.fsf@fimbulvetr.bsc.es> In-Reply-To: <87vck8xfvy.fsf@fimbulvetr.bsc.es> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH 1/3] monitor: remove unused do_info_trace List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?ISO-8859-1?Q?Llu=EDs_Vilanova?= Cc: aneesh.kumar@linux.vnet.ibm.com, qemu-devel@nongnu.org, stefanha@linux.vnet.ibm.com On 05/07/2012 07:16 PM, Lluís Vilanova wrote: > Harsh Prateek Bora writes: > >> Going forward with simpletrace v2 variable size trace records, we cannot >> have a generic function to print trace event info and therefore this >> interface becomes invalid. > >> As per Stefan Hajnoczi: > >> "This command is only available from the human monitor. It's not very >> useful because it historically hasn't been able to pretty-print events >> or show them in the right order (we use a ringbuffer but it prints >> them out from index 0). > >> Therefore, I don't think we're under any obligation to keep this >> command around. No one has complained about it's limitations - I >> think this is a sign that no one has used it. I'd be okay with a >> patch that removes it." > >> Ref: http://lists.gnu.org/archive/html/qemu-devel/2012-01/msg01268.html > > Eliminating 'do_info_trace' makes 'st_print_trace' unused; so maybe it could > also be eliminated. > Yeah, though that gets removed in 2/3 patch, it makes sense to remove that here. - Harsh > > Lluis > > >> Signed-off-by: Harsh Prateek Bora >> --- >> monitor.c | 16 ---------------- >> 1 files changed, 0 insertions(+), 16 deletions(-) > >> diff --git a/monitor.c b/monitor.c >> index 8946a10..bebf864 100644 >> --- a/monitor.c >> +++ b/monitor.c >> @@ -812,13 +812,6 @@ static void do_info_cpu_stats(Monitor *mon) >> } >> #endif > >> -#if defined(CONFIG_TRACE_SIMPLE) >> -static void do_info_trace(Monitor *mon) >> -{ >> - st_print_trace((FILE *)mon,&monitor_fprintf); >> -} >> -#endif >> - >> static void do_trace_print_events(Monitor *mon) >> { >> trace_print_events((FILE *)mon,&monitor_fprintf); >> @@ -2585,15 +2578,6 @@ static mon_cmd_t info_cmds[] = { >> .help = "show roms", >> .mhandler.info = do_info_roms, >> }, >> -#if defined(CONFIG_TRACE_SIMPLE) >> - { >> - .name = "trace", >> - .args_type = "", >> - .params = "", >> - .help = "show current contents of trace buffer", >> - .mhandler.info = do_info_trace, >> - }, >> -#endif >> { >> .name = "trace-events", >> .args_type = "", >> -- >> 1.7.1.1 > > >