From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:58200) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SRjHF-0005jX-6c for qemu-devel@nongnu.org; Tue, 08 May 2012 08:12:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SRjH8-0008El-Pk for qemu-devel@nongnu.org; Tue, 08 May 2012 08:12:24 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59029) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SRjH8-0008EX-HB for qemu-devel@nongnu.org; Tue, 08 May 2012 08:12:18 -0400 Message-ID: <4FA90DA0.9000309@redhat.com> Date: Tue, 08 May 2012 14:12:16 +0200 From: Hans de Goede MIME-Version: 1.0 References: <1336478816-32522-1-git-send-email-kraxel@redhat.com> In-Reply-To: <1336478816-32522-1-git-send-email-kraxel@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] usb-host: handle guest-issued clear halt List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: erik.rull@rdsoftware.de, qemu-devel@nongnu.org Looks good, ACK. On 05/08/2012 02:06 PM, Gerd Hoffmann wrote: > Most important here is to update our internal endpoint state so we know > the endpoint isn't in halted state any more. Without this usb-host > tries to clear halt again with the next data transfer submitted. Doing > this twice is (a) not correct and (b) confuses some usb devices, > rendering them non-functional in the guest. > > Signed-off-by: Gerd Hoffmann > --- > hw/usb/host-linux.c | 9 +++++++++ > 1 files changed, 9 insertions(+), 0 deletions(-) > > diff --git a/hw/usb/host-linux.c b/hw/usb/host-linux.c > index bb08542..9094120 100644 > --- a/hw/usb/host-linux.c > +++ b/hw/usb/host-linux.c > @@ -1101,6 +1101,15 @@ static int usb_host_handle_control(USBDevice *dev, USBPacket *p, > ret = usb_host_set_interface(s, index, value); > trace_usb_host_req_emulated(s->bus_num, s->addr, p, ret); > return ret; > + > + case EndpointOutRequest | USB_REQ_CLEAR_FEATURE: > + if (value == 0) { /* clear halt */ > + int pid = (index& USB_DIR_IN) ? USB_TOKEN_IN : USB_TOKEN_OUT; > + ioctl(s->fd, USBDEVFS_CLEAR_HALT,&index); > + clear_halt(s, pid, index& 0x0f); > + trace_usb_host_req_emulated(s->bus_num, s->addr, p, 0); > + return 0; > + } > } > > /* The rest are asynchronous */