* [Qemu-devel] [PATCH 1.1] tci: Fix wrong macro name for debug code
@ 2012-05-03 16:09 Stefan Weil
2012-05-03 16:15 ` Peter Maydell
2012-05-08 17:28 ` Anthony Liguori
0 siblings, 2 replies; 3+ messages in thread
From: Stefan Weil @ 2012-05-03 16:09 UTC (permalink / raw)
To: qemu-devel; +Cc: Stefan Weil, Anthony Liguori
Code which is compiled with CONFIG_TCG_DEBUG (set by configure option
--enable-debug-tcg) should not disable the assert macro by
defining NDEBUG.
With the wrong macro name CONFIG_TCG_DEBUG, all assertions in tci.c
were completely useless because NDEBUG was always defined.
Signed-off-by: Stefan Weil <sw@weilnetz.de>
---
tci.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
Please apply this fix before the release of QEMU 1.1.
Thanks,
Stefan Weil
diff --git a/tci.c b/tci.c
index 23a8368..e40c080 100644
--- a/tci.c
+++ b/tci.c
@@ -20,7 +20,7 @@
#include "config.h"
/* Defining NDEBUG disables assertions (which makes the code faster). */
-#if !defined(CONFIG_TCG_DEBUG) && !defined(NDEBUG)
+#if !defined(CONFIG_DEBUG_TCG) && !defined(NDEBUG)
# define NDEBUG
#endif
--
1.7.9
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH 1.1] tci: Fix wrong macro name for debug code
2012-05-03 16:09 [Qemu-devel] [PATCH 1.1] tci: Fix wrong macro name for debug code Stefan Weil
@ 2012-05-03 16:15 ` Peter Maydell
2012-05-08 17:28 ` Anthony Liguori
1 sibling, 0 replies; 3+ messages in thread
From: Peter Maydell @ 2012-05-03 16:15 UTC (permalink / raw)
To: Stefan Weil; +Cc: Anthony Liguori, qemu-devel
On 3 May 2012 17:09, Stefan Weil <sw@weilnetz.de> wrote:
> Code which is compiled with CONFIG_TCG_DEBUG (set by configure option
> --enable-debug-tcg) should not disable the assert macro by
> defining NDEBUG.
>
> With the wrong macro name CONFIG_TCG_DEBUG, all assertions in tci.c
> were completely useless because NDEBUG was always defined.
>
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
This now matches the equivalent check in tcg/tcg.c.
-- PMM
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH 1.1] tci: Fix wrong macro name for debug code
2012-05-03 16:09 [Qemu-devel] [PATCH 1.1] tci: Fix wrong macro name for debug code Stefan Weil
2012-05-03 16:15 ` Peter Maydell
@ 2012-05-08 17:28 ` Anthony Liguori
1 sibling, 0 replies; 3+ messages in thread
From: Anthony Liguori @ 2012-05-08 17:28 UTC (permalink / raw)
To: Stefan Weil; +Cc: qemu-devel
On 05/03/2012 11:09 AM, Stefan Weil wrote:
> Code which is compiled with CONFIG_TCG_DEBUG (set by configure option
> --enable-debug-tcg) should not disable the assert macro by
> defining NDEBUG.
>
> With the wrong macro name CONFIG_TCG_DEBUG, all assertions in tci.c
> were completely useless because NDEBUG was always defined.
>
> Signed-off-by: Stefan Weil<sw@weilnetz.de>
Applied. Thanks.
Regards,
Anthony Liguori
> ---
> tci.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> Please apply this fix before the release of QEMU 1.1.
>
> Thanks,
>
> Stefan Weil
>
> diff --git a/tci.c b/tci.c
> index 23a8368..e40c080 100644
> --- a/tci.c
> +++ b/tci.c
> @@ -20,7 +20,7 @@
> #include "config.h"
>
> /* Defining NDEBUG disables assertions (which makes the code faster). */
> -#if !defined(CONFIG_TCG_DEBUG)&& !defined(NDEBUG)
> +#if !defined(CONFIG_DEBUG_TCG)&& !defined(NDEBUG)
> # define NDEBUG
> #endif
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-05-08 17:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-05-03 16:09 [Qemu-devel] [PATCH 1.1] tci: Fix wrong macro name for debug code Stefan Weil
2012-05-03 16:15 ` Peter Maydell
2012-05-08 17:28 ` Anthony Liguori
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).