From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:53352) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SRoDe-0004HQ-HS for qemu-devel@nongnu.org; Tue, 08 May 2012 13:29:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SRoDZ-0000hU-Iy for qemu-devel@nongnu.org; Tue, 08 May 2012 13:29:02 -0400 Received: from e7.ny.us.ibm.com ([32.97.182.137]:52974) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SRoDZ-0000cS-FA for qemu-devel@nongnu.org; Tue, 08 May 2012 13:28:57 -0400 Received: from /spool/local by e7.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 8 May 2012 13:28:53 -0400 Received: from d01relay04.pok.ibm.com (d01relay04.pok.ibm.com [9.56.227.236]) by d01dlp02.pok.ibm.com (Postfix) with ESMTP id DDD136E8062 for ; Tue, 8 May 2012 13:28:49 -0400 (EDT) Received: from d03av06.boulder.ibm.com (d03av06.boulder.ibm.com [9.17.195.245]) by d01relay04.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q48HSlqP098754 for ; Tue, 8 May 2012 13:28:47 -0400 Received: from d03av06.boulder.ibm.com (loopback [127.0.0.1]) by d03av06.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q48HTQDp017934 for ; Tue, 8 May 2012 11:29:26 -0600 Message-ID: <4FA957CE.5050301@us.ibm.com> Date: Tue, 08 May 2012 12:28:46 -0500 From: Anthony Liguori MIME-Version: 1.0 References: <1336061385-5743-1-git-send-email-sw@weilnetz.de> In-Reply-To: <1336061385-5743-1-git-send-email-sw@weilnetz.de> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1.1] tci: Fix wrong macro name for debug code List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Weil Cc: qemu-devel@nongnu.org On 05/03/2012 11:09 AM, Stefan Weil wrote: > Code which is compiled with CONFIG_TCG_DEBUG (set by configure option > --enable-debug-tcg) should not disable the assert macro by > defining NDEBUG. > > With the wrong macro name CONFIG_TCG_DEBUG, all assertions in tci.c > were completely useless because NDEBUG was always defined. > > Signed-off-by: Stefan Weil Applied. Thanks. Regards, Anthony Liguori > --- > tci.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > Please apply this fix before the release of QEMU 1.1. > > Thanks, > > Stefan Weil > > diff --git a/tci.c b/tci.c > index 23a8368..e40c080 100644 > --- a/tci.c > +++ b/tci.c > @@ -20,7 +20,7 @@ > #include "config.h" > > /* Defining NDEBUG disables assertions (which makes the code faster). */ > -#if !defined(CONFIG_TCG_DEBUG)&& !defined(NDEBUG) > +#if !defined(CONFIG_DEBUG_TCG)&& !defined(NDEBUG) > # define NDEBUG > #endif >