From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:40252) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SRq6N-0002m8-3l for qemu-devel@nongnu.org; Tue, 08 May 2012 15:29:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SRq6K-0006f2-Ss for qemu-devel@nongnu.org; Tue, 08 May 2012 15:29:38 -0400 Message-ID: <4FA9741D.10804@suse.de> Date: Tue, 08 May 2012 21:29:33 +0200 From: =?ISO-8859-1?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1336347984-3714-1-git-send-email-afaerber@suse.de> <879932B6-7B16-4ED2-971F-5BC708B5BDCF@suse.de> <1BDFB320-4ADB-4D97-972A-0031BF6FF305@suse.de> In-Reply-To: <1BDFB320-4ADB-4D97-972A-0031BF6FF305@suse.de> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [Qemu-ppc] [PATCH for-1.1 0/3] tcg/ppc: AREG0 support and Darwin fixes List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf Cc: qemu-ppc , qemu-devel Developers Am 08.05.2012 20:09, schrieb Alexander Graf: >=20 > On 08.05.2012, at 19:39, malc wrote: >=20 >> On Tue, 8 May 2012, Alexander Graf wrote: >> >>> On 07.05.2012, at 01:46, Andreas F?rber wrote: >>> >>>> This series fixes two long-standing issues on Darwin/ppc and, based = on your >>>> second patch, fixes the AREG0 mode for Linux and Darwin and thus the= ppc build. >>>> >>>> Compared to your last patch I have tried to avoid the { int ir; } bl= ock, and >>>> I've combined both modes in one code path using ir and a new macro t= o handle >>>> the alignment differences in a more explicit way. >>>> >>>> Tested on Linux and Darwin, using i386 and x86_64 (non-AREG0) as wel= l as sparc >>>> and sparc64 (AREG0). On Darwin I observed a reproducible hang in fsc= k during >>>> INIT under Debian/sparc, which given the lateness and now unified co= de paths >>>> (i.e., Haiku/i386 and HelenOS/sparc64 working) I'd attribute to ling= ering >>>> main loop / signal handling issues. What I was referring to here btw is that I've in one case seen Haiku continue shutting down once I grabbed and moved the mouse in Cocoa. Not observed on Linux with SDL or VNC. >>> Malc, ping? :) >> >> I raised my minor objections to Andreas on IRC, they are not yet >> addressed. >=20 > Like? I'd like to have a working rc1. He didn't like my _CALL_DARWIN fix in patch 2/3 (which is totally independent of 3/3). On patch 3/3 he didn't like my alignment macro. I don't have a better one though, suggestions or patches welcome. Ideal might be some ROUND_TO_ODD() macro, but the problem is that for Darwin/AIX where it's no-op it shouldn't result in a "statement without effect" warning. Therefore my do { } while (0) as opposed to ir =3D MACRO(ir). I do think though that any half-baked patch that doesn't regress is better than the current #error situation. Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg