From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:49393)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1SRqPg-0000aX-Ec
	for qemu-devel@nongnu.org; Tue, 08 May 2012 15:49:37 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1SRqPe-0006yC-KV
	for qemu-devel@nongnu.org; Tue, 08 May 2012 15:49:36 -0400
Message-ID: <4FA978CB.6010408@suse.de>
Date: Tue, 08 May 2012 21:49:31 +0200
From: =?ISO-8859-1?Q?Andreas_F=E4rber?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1336347984-3714-1-git-send-email-afaerber@suse.de>
	<879932B6-7B16-4ED2-971F-5BC708B5BDCF@suse.de>
	<alpine.LNX.2.00.1205082139210.6245@linmac>
In-Reply-To: <alpine.LNX.2.00.1205082139210.6245@linmac>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [Qemu-ppc] [PATCH for-1.1 0/3] tcg/ppc: AREG0
 support and Darwin fixes
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: malc <av1474@comtv.ru>
Cc: qemu-ppc <qemu-ppc@nongnu.org>, Alexander Graf <agraf@suse.de>, qemu-devel Developers <qemu-devel@nongnu.org>

Am 08.05.2012 19:39, schrieb malc:
> On Tue, 8 May 2012, Alexander Graf wrote:
>=20
>>
>> On 07.05.2012, at 01:46, Andreas F?rber wrote:
>>
>>> Hello malc,
>>>
>>> This series fixes two long-standing issues on Darwin/ppc and, based o=
n your
>>> second patch, fixes the AREG0 mode for Linux and Darwin and thus the =
ppc build.
>>>
>>> Compared to your last patch I have tried to avoid the { int ir; } blo=
ck, and
>>> I've combined both modes in one code path using ir and a new macro to=
 handle
>>> the alignment differences in a more explicit way.
>>>
>>> Tested on Linux and Darwin, using i386 and x86_64 (non-AREG0) as well=
 as sparc
>>> and sparc64 (AREG0). On Darwin I observed a reproducible hang in fsck=
 during
>>> INIT under Debian/sparc, which given the lateness and now unified cod=
e paths
>>> (i.e., Haiku/i386 and HelenOS/sparc64 working) I'd attribute to linge=
ring
>>> main loop / signal handling issues.
>>>
>>> Regards,
>>> Andreas
>>>
>>> Cc: malc <av1474@comtv.ru>
>>
>> Malc, ping? :)
>=20
> I raised my minor objections to Andreas on IRC, they are not yet
> addressed.

Do you have any better suggestion based on the gcc output you requested?
Should I rather replace all #ifdef _CALL_DARWIN with #if defined
_CALL_DARWIN || defined __APPLE__, as seen in tcg-target.h?

Andreas

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe=
rg