From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:44102) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SRvJS-0002B1-Iw for qemu-devel@nongnu.org; Tue, 08 May 2012 21:03:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SRvJQ-0006Q7-I8 for qemu-devel@nongnu.org; Tue, 08 May 2012 21:03:30 -0400 Message-ID: <4FA9C25D.2030904@suse.de> Date: Wed, 09 May 2012 03:03:25 +0200 From: =?ISO-8859-1?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1336523290-6899-1-git-send-email-afaerber@suse.de> <1336523290-6899-5-git-send-email-afaerber@suse.de> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v2 for-1.1 4/4] tcg/ppc: Fix CONFIG_TCG_PASS_AREG0 mode List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: malc Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org, agraf@suse.de Am 09.05.2012 02:43, schrieb malc: > On Wed, 9 May 2012, Andreas F?rber wrote: >=20 >> Adjust the tcg_out_qemu_{ld,st}() slow paths to pass AREG0 in r3, >> based on patches by malc. >> >> Also adjust the registers clobbered, based on patch by Alex. >=20 > Alexander, my head is splitting now, so i can not calculate things insi= de > it, aren't we reserving skipped registers in some circumstances? Yes, we are. The original code did, and Alex found it too complicated for the immediate build fix when I suggested it. As you can see, I've already split up into AREG0 and non #ifdef paths because it got too unreadable when having one line with multiple or'ed #if conditions. Optimizations we can still do when the build is restored. Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg