From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:36476) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SS3XL-0003bh-J0 for qemu-devel@nongnu.org; Wed, 09 May 2012 05:50:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SS3XG-0005di-24 for qemu-devel@nongnu.org; Wed, 09 May 2012 05:50:23 -0400 Received: from mx1.redhat.com ([209.132.183.28]:16478) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SS3XF-0005db-QA for qemu-devel@nongnu.org; Wed, 09 May 2012 05:50:17 -0400 Message-ID: <4FAA3DD3.1060402@redhat.com> Date: Wed, 09 May 2012 11:50:11 +0200 From: Kevin Wolf MIME-Version: 1.0 References: <1336555446-20180-1-git-send-email-jim@meyering.net> <1336555446-20180-2-git-send-email-jim@meyering.net> In-Reply-To: <1336555446-20180-2-git-send-email-jim@meyering.net> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 01/22] block: avoid buffer overrun by using pstrcpy, not strncpy List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jim Meyering Cc: Jim Meyering , qemu-devel@nongnu.org Am 09.05.2012 11:23, schrieb Jim Meyering: > From: Jim Meyering > > Also, use PATH_MAX, rather than the arbitrary 1024. > Using PATH_MAX is more consistent with other filename-related > variables in this file, like backing_filename and tmp_filename. > > Signed-off-by: Jim Meyering Not absolutely required because the source buffer is 1024 bytes and null terminated as well, but it doesn't hurt either. Acked-by: Kevin Wolf