From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:59511) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SS4MR-0000uK-CE for qemu-devel@nongnu.org; Wed, 09 May 2012 06:43:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SS4MM-0000XI-6g for qemu-devel@nongnu.org; Wed, 09 May 2012 06:43:10 -0400 Received: from e06smtp11.uk.ibm.com ([195.75.94.107]:34550) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SS4ML-0000Wx-V5 for qemu-devel@nongnu.org; Wed, 09 May 2012 06:43:06 -0400 Received: from /spool/local by e06smtp11.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 9 May 2012 11:43:03 +0100 Received: from d06av09.portsmouth.uk.ibm.com (d06av09.portsmouth.uk.ibm.com [9.149.37.250]) by d06nrmr1307.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q49Ah1Gh2166872 for ; Wed, 9 May 2012 11:43:01 +0100 Received: from d06av09.portsmouth.uk.ibm.com (loopback [127.0.0.1]) by d06av09.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q49Ah04T023310 for ; Wed, 9 May 2012 04:43:01 -0600 Message-ID: <4FAA4A32.3000605@de.ibm.com> Date: Wed, 09 May 2012 12:42:58 +0200 From: Christian Borntraeger MIME-Version: 1.0 References: <4EC02384-64EF-4514-975C-A3D229B3693E@suse.de> <1336055277-53204-1-git-send-email-borntraeger@de.ibm.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] Fix size checking in load_image_targphys to accept max_size > INT_MAX List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: QEMU Developers , Peter Maydell , agraf@suse.de On 03/05/12 16:33, Peter Maydell wrote: >> Since load_image_targphys is declared as taking an int for max_sz, this will >> fail for ram sizes > INT_MAX. >> Lets change the max_sz parameter to a uint64_t. >> >> Signed-off-by: Christian Borntraeger > > A patch equivalent to this has already been submitted: > http://patchwork.ozlabs.org/patch/146165/ > We should be applying that one, it has already been reviewed. > > Anthony? Ping?