From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:57142) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SS5oA-0000EA-HF for qemu-devel@nongnu.org; Wed, 09 May 2012 08:15:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SS5o4-00088w-79 for qemu-devel@nongnu.org; Wed, 09 May 2012 08:15:54 -0400 Received: from mx1.redhat.com ([209.132.183.28]:64758) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SS5o3-00088m-VL for qemu-devel@nongnu.org; Wed, 09 May 2012 08:15:48 -0400 Message-ID: <4FAA5FEC.1070900@redhat.com> Date: Wed, 09 May 2012 14:15:40 +0200 From: Kevin Wolf MIME-Version: 1.0 References: <1336488722-13120-1-git-send-email-pbonzini@redhat.com> <1336488722-13120-2-git-send-email-pbonzini@redhat.com> In-Reply-To: <1336488722-13120-2-git-send-email-pbonzini@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1.1 01/22] block: fix snapshot on QED List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: Markus Armbruster , qemu-devel@nongnu.org, stefanha@linux.vnet.ibm.com Am 08.05.2012 16:51, schrieb Paolo Bonzini: > QED's opaque data includes a pointer back to the BlockDriverState. > This breaks when bdrv_append shuffles data between bs_new and bs_top. > To avoid this, add a "rebind" function that tells the driver about > the new relationship between the BlockDriverState and its opaque. > > The patch also adds rebind to VVFAT for completeness, even though > it is not used with live snapshots. > > Reviewed-by: Stefan Hajnoczi > Reviewed-by: Kevin Wolf > Signed-off-by: Paolo Bonzini I still don't like this patch. We'll not get the proper solution in time for 1.1, but I hope that we can get rid of bdrv_rebind() again when BlockDriverState and the block device backend are split and devices no longer have direct pointers to BlockDriverStates. Kevin