From: Alexander Graf <agraf@suse.de>
To: Hannes Reinecke <hare@suse.de>
Cc: Gerhard Wiesinger <lists@wiesinger.com>,
Paolo Bonzini <pbonzini@redhat.com>,
qemu-devel@nongnu.org, Andreas Faerber <afaerber@suse.de>
Subject: Re: [Qemu-devel] [PATCH 2/3] megasas: LSI Megaraid SAS HBA emulation
Date: Wed, 09 May 2012 15:02:37 +0200 [thread overview]
Message-ID: <4FAA6AED.7030609@suse.de> (raw)
In-Reply-To: <1336557163-23645-3-git-send-email-hare@suse.de>
On 05/09/2012 11:52 AM, Hannes Reinecke wrote:
> This patch adds an emulation for the LSI Megaraid SAS 8708EM2 HBA.
> I've tested it to work with Linux, Windows Vista, and Windows7.
agraf@wolfberry-1:/home/agraf/git/qemu.megasas> git pw am 157890
ERROR: return is not a function, parentheses are not required
#303: FILE: hw/megasas.c:246:
+ return (iov_count - i);
WARNING: braces {} are necessary for all arms of this statement
#653: FILE: hw/megasas.c:596:
+ if (cmd->frame->header.sge_count)
[...]
WARNING: braces {} are necessary for all arms of this statement
#1047: FILE: hw/megasas.c:990:
+ if (num_ld_disks >= max_ld_disks)
[...]
WARNING: braces {} are necessary for all arms of this statement
#1513: FILE: hw/megasas.c:1456:
+ if (cmd->frame->header.frame_cmd == MFI_CMD_DCMD)
[...]
+ else
[...]
total: 1 errors, 3 warnings, 1978 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
checkpatch failed, still apply? [y|N]
next prev parent reply other threads:[~2012-05-09 13:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-09 9:52 [Qemu-devel] [PATCH 0/3][v16] LSI Megaraid SAS HBA emulation Hannes Reinecke
2012-05-09 9:52 ` [Qemu-devel] [PATCH 1/3] megasas: Add header file Hannes Reinecke
2012-05-09 9:52 ` [Qemu-devel] [PATCH 2/3] megasas: LSI Megaraid SAS HBA emulation Hannes Reinecke
2012-05-09 13:02 ` Alexander Graf [this message]
2012-05-09 14:15 ` Hannes Reinecke
2012-05-09 9:52 ` [Qemu-devel] [PATCH 3/3] megasas: Add trace events Hannes Reinecke
2012-05-09 13:03 ` Alexander Graf
-- strict thread matches above, loose matches on Subject: below --
2012-05-09 14:13 [Qemu-devel] [PATCH 0/3][v17] LSI Megaraid SAS HBA emulation Hannes Reinecke
2012-05-09 14:13 ` [Qemu-devel] [PATCH 2/3] megasas: " Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FAA6AED.7030609@suse.de \
--to=agraf@suse.de \
--cc=afaerber@suse.de \
--cc=hare@suse.de \
--cc=lists@wiesinger.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).