From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:51448)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <agraf@suse.de>) id 1SS6XX-00013j-9q
	for qemu-devel@nongnu.org; Wed, 09 May 2012 09:02:48 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <agraf@suse.de>) id 1SS6XQ-0003Lj-4o
	for qemu-devel@nongnu.org; Wed, 09 May 2012 09:02:46 -0400
Received: from cantor2.suse.de ([195.135.220.15]:41153 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <agraf@suse.de>) id 1SS6XP-0003LJ-Um
	for qemu-devel@nongnu.org; Wed, 09 May 2012 09:02:40 -0400
Message-ID: <4FAA6AED.7030609@suse.de>
Date: Wed, 09 May 2012 15:02:37 +0200
From: Alexander Graf <agraf@suse.de>
MIME-Version: 1.0
References: <1336557163-23645-1-git-send-email-hare@suse.de>
	<1336557163-23645-3-git-send-email-hare@suse.de>
In-Reply-To: <1336557163-23645-3-git-send-email-hare@suse.de>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 2/3] megasas: LSI Megaraid SAS HBA emulation
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Hannes Reinecke <hare@suse.de>
Cc: Gerhard Wiesinger <lists@wiesinger.com>, Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org, Andreas Faerber <afaerber@suse.de>

On 05/09/2012 11:52 AM, Hannes Reinecke wrote:
> This patch adds an emulation for the LSI Megaraid SAS 8708EM2 HBA.
> I've tested it to work with Linux, Windows Vista, and Windows7.

agraf@wolfberry-1:/home/agraf/git/qemu.megasas> git pw am 157890
ERROR: return is not a function, parentheses are not required
#303: FILE: hw/megasas.c:246:
+    return (iov_count - i);

WARNING: braces {} are necessary for all arms of this statement
#653: FILE: hw/megasas.c:596:
+    if (cmd->frame->header.sge_count)
[...]

WARNING: braces {} are necessary for all arms of this statement
#1047: FILE: hw/megasas.c:990:
+        if (num_ld_disks >= max_ld_disks)
[...]

WARNING: braces {} are necessary for all arms of this statement
#1513: FILE: hw/megasas.c:1456:
+    if (cmd->frame->header.frame_cmd == MFI_CMD_DCMD)
[...]
+    else
[...]

total: 1 errors, 3 warnings, 1978 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
checkpatch failed, still apply? [y|N]