Re: [Qemu-devel] [PATCH 3/3] megasas: Add trace events

[Alexander Graf <agraf@suse.de>]

On 05/09/2012 11:52 AM, Hannes Reinecke wrote:
> This patch add trace events to the megasas HBA emulation.


agraf@wolfberry-1:/home/agraf/git/qemu.megasas> git pw am 157891
WARNING: line over 80 characters
#233: FILE: hw/megasas.c:872:
+                                            offset + sizeof(struct 
mfi_pd_address));

WARNING: line over 80 characters
#241: FILE: hw/megasas.c:896:
+    trace_megasas_dcmd_pd_get_list(cmd->index, num_pd_disks, 
max_pd_disks, offset);

ERROR: space required after that ',' (ctx:VxV)
#349: FILE: hw/megasas.c:1294:
+            dummy[0x00], dummy[0x01],dummy[0x02], dummy[0x03],
                                      ^

WARNING: line over 80 characters
#433: FILE: hw/megasas.c:1332:
+    { MFI_DCMD_CTRL_MFI_HOST_MEM_ALLOC, "CTRL_HOST_MEM_ALLOC", 
megasas_dcmd_dummy },

WARNING: line over 80 characters
#435: FILE: hw/megasas.c:1334:
+    { MFI_DCMD_CTRL_GET_PROPERTIES, "CTRL_GET_PROPERTIES", 
megasas_dcmd_get_properties },

WARNING: line over 80 characters
#436: FILE: hw/megasas.c:1335:
+    { MFI_DCMD_CTRL_SET_PROPERTIES, "CTRL_SET_PROPERTIES", 
megasas_dcmd_set_properties },

WARNING: line over 80 characters
#449: FILE: hw/megasas.c:1348:
+    { MFI_DCMD_CTRL_BIOS_DATA_GET, "CTRL_BIOS_DATA_GET", 
megasas_dcmd_get_bios_info },

WARNING: line over 80 characters
#450: FILE: hw/megasas.c:1349:
+    { MFI_DCMD_CTRL_FACTORY_DEFAULTS, "CTRL_FACTORY_DEFAULTS", 
megasas_dcmd_dummy },

WARNING: line over 80 characters
#451: FILE: hw/megasas.c:1350:
+    { MFI_DCMD_CTRL_MFC_DEFAULTS_GET, "CTRL_MFC_DEFAULTS_GET", 
megasas_mfc_get_defaults },

WARNING: line over 80 characters
#452: FILE: hw/megasas.c:1351:
+    { MFI_DCMD_CTRL_MFC_DEFAULTS_SET, "CTRL_MFC_DEFAULTS_SET", 
megasas_dcmd_dummy },

total: 1 errors, 9 warnings, 792 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
checkpatch failed, still apply? [y|N]