From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:51567)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <agraf@suse.de>) id 1SS6YH-0001nL-2d
	for qemu-devel@nongnu.org; Wed, 09 May 2012 09:03:37 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <agraf@suse.de>) id 1SS6YA-0003kW-LA
	for qemu-devel@nongnu.org; Wed, 09 May 2012 09:03:32 -0400
Received: from cantor2.suse.de ([195.135.220.15]:41183 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <agraf@suse.de>) id 1SS6YA-0003il-8W
	for qemu-devel@nongnu.org; Wed, 09 May 2012 09:03:26 -0400
Message-ID: <4FAA6B1C.2010709@suse.de>
Date: Wed, 09 May 2012 15:03:24 +0200
From: Alexander Graf <agraf@suse.de>
MIME-Version: 1.0
References: <1336557163-23645-1-git-send-email-hare@suse.de>
	<1336557163-23645-4-git-send-email-hare@suse.de>
In-Reply-To: <1336557163-23645-4-git-send-email-hare@suse.de>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 3/3] megasas: Add trace events
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Hannes Reinecke <hare@suse.de>
Cc: Gerhard Wiesinger <lists@wiesinger.com>, Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org, Andreas Faerber <afaerber@suse.de>

On 05/09/2012 11:52 AM, Hannes Reinecke wrote:
> This patch add trace events to the megasas HBA emulation.


agraf@wolfberry-1:/home/agraf/git/qemu.megasas> git pw am 157891
WARNING: line over 80 characters
#233: FILE: hw/megasas.c:872:
+                                            offset + sizeof(struct 
mfi_pd_address));

WARNING: line over 80 characters
#241: FILE: hw/megasas.c:896:
+    trace_megasas_dcmd_pd_get_list(cmd->index, num_pd_disks, 
max_pd_disks, offset);

ERROR: space required after that ',' (ctx:VxV)
#349: FILE: hw/megasas.c:1294:
+            dummy[0x00], dummy[0x01],dummy[0x02], dummy[0x03],
                                      ^

WARNING: line over 80 characters
#433: FILE: hw/megasas.c:1332:
+    { MFI_DCMD_CTRL_MFI_HOST_MEM_ALLOC, "CTRL_HOST_MEM_ALLOC", 
megasas_dcmd_dummy },

WARNING: line over 80 characters
#435: FILE: hw/megasas.c:1334:
+    { MFI_DCMD_CTRL_GET_PROPERTIES, "CTRL_GET_PROPERTIES", 
megasas_dcmd_get_properties },

WARNING: line over 80 characters
#436: FILE: hw/megasas.c:1335:
+    { MFI_DCMD_CTRL_SET_PROPERTIES, "CTRL_SET_PROPERTIES", 
megasas_dcmd_set_properties },

WARNING: line over 80 characters
#449: FILE: hw/megasas.c:1348:
+    { MFI_DCMD_CTRL_BIOS_DATA_GET, "CTRL_BIOS_DATA_GET", 
megasas_dcmd_get_bios_info },

WARNING: line over 80 characters
#450: FILE: hw/megasas.c:1349:
+    { MFI_DCMD_CTRL_FACTORY_DEFAULTS, "CTRL_FACTORY_DEFAULTS", 
megasas_dcmd_dummy },

WARNING: line over 80 characters
#451: FILE: hw/megasas.c:1350:
+    { MFI_DCMD_CTRL_MFC_DEFAULTS_GET, "CTRL_MFC_DEFAULTS_GET", 
megasas_mfc_get_defaults },

WARNING: line over 80 characters
#452: FILE: hw/megasas.c:1351:
+    { MFI_DCMD_CTRL_MFC_DEFAULTS_SET, "CTRL_MFC_DEFAULTS_SET", 
megasas_dcmd_dummy },

total: 1 errors, 9 warnings, 792 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
checkpatch failed, still apply? [y|N]