[Qemu-devel] get_maintainer.pl prints invalid Cc: [Re: Fwd: Undelivered Mail Returned to Sender

[Qemu-devel] get_maintainer.pl prints invalid Cc: [Re: Fwd: Undelivered Mail Returned to Sender

[Jim Meyering]

Alexander Graf wrote:
> Hrm :)

That appears to be due to scripts/get_maintainer.pl not sanitizing
its output addresses.  E.g., using my 06/22 patch, I get this bogus Cc:

    $ scripts/get_maintainer.pl 0006-*|grep open
    qemu-devel@nongnu.org (open list:POSIX)

> -------- Original Message --------
> Subject: Undelivered Mail Returned to Sender
>    Date: Wed, 9 May 2012 13:54:24 +0200 (CEST)
>    From: MAILER-DAEMON@suse.de (Mail Delivery System)
>      To: agraf@suse.de
>
> This is the Postfix program at host mx2.suse.de.
>
> I'm sorry to have to inform you that your message could not be
> be delivered to one or more recipients. It's attached below.
>
> For further assistance, please send mail to <postmaster>
>
> If you do so, please include this problem report. You can
> delete your own text from the attached returned message.
>
>                         The Postfix program
>
> <qemu-devel@nongnu.org>: host eggs.gnu.org[208.118.235.92] said: 550 Invalid
>     address in message header (in reply to end of DATA command)
>
> <qemu-ppc@nongnu.org>: host eggs.gnu.org[208.118.235.92] said: 550 Invalid
>     address in message header (in reply to end of DATA command)

Re: [Qemu-devel] get_maintainer.pl prints invalid Cc: [Re: Fwd: Undelivered Mail Returned to Sender

[Andreas Färber]

Am 09.05.2012 14:38, schrieb Jim Meyering:
> Alexander Graf wrote:
>> Hrm :)
> 
> That appears to be due to scripts/get_maintainer.pl not sanitizing
> its output addresses.  E.g., using my 06/22 patch, I get this bogus Cc:
> 
>     $ scripts/get_maintainer.pl 0006-*|grep open
>     qemu-devel@nongnu.org (open list:POSIX)

What's bogus about that? The email address is that of our mailing list,
we use it for subsystems where we don't have a particular maintainer. L:
gets translated to "open list" and the MAINTAINERS section is apparently
titled "POSIX". Comments to be ignored by MTAs can be indicated in
parenthesis as far as I remember RFC822, so it seems semantically and
syntactically correct. What would need to be sanitized?

I have once seen that break when replying to messages though. Maybe when
the list of CCs gets broken into multiple lines? That would be a
git-send-email or MUA problem then though.

Andreas

>> -------- Original Message --------
>> Subject: Undelivered Mail Returned to Sender
>>    Date: Wed, 9 May 2012 13:54:24 +0200 (CEST)
>>    From: MAILER-DAEMON@suse.de (Mail Delivery System)
>>      To: agraf@suse.de
>>
>> This is the Postfix program at host mx2.suse.de.
>>
>> I'm sorry to have to inform you that your message could not be
>> be delivered to one or more recipients. It's attached below.
>>
>> For further assistance, please send mail to <postmaster>
>>
>> If you do so, please include this problem report. You can
>> delete your own text from the attached returned message.
>>
>>                         The Postfix program
>>
>> <qemu-devel@nongnu.org>: host eggs.gnu.org[208.118.235.92] said: 550 Invalid
>>     address in message header (in reply to end of DATA command)
>>
>> <qemu-ppc@nongnu.org>: host eggs.gnu.org[208.118.235.92] said: 550 Invalid
>>     address in message header (in reply to end of DATA command)

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg

Re: [Qemu-devel] get_maintainer.pl prints invalid Cc: [Re: Fwd: Undelivered Mail Returned to Sender

[Jim Meyering]

Andreas Färber wrote:
> Am 09.05.2012 14:38, schrieb Jim Meyering:
>> Alexander Graf wrote:
>>> Hrm :)
>>
>> That appears to be due to scripts/get_maintainer.pl not sanitizing
>> its output addresses.  E.g., using my 06/22 patch, I get this bogus Cc:
>>
>>     $ scripts/get_maintainer.pl 0006-*|grep open
>>     qemu-devel@nongnu.org (open list:POSIX)
>
> What's bogus about that? The email address is that of our mailing list,
> we use it for subsystems where we don't have a particular maintainer. L:
> gets translated to "open list" and the MAINTAINERS section is apparently
> titled "POSIX". Comments to be ignored by MTAs can be indicated in
> parenthesis as far as I remember RFC822, so it seems semantically and
> syntactically correct. What would need to be sanitized?

You're right.  The parenthesized quantity should be ignored.

> I have once seen that break when replying to messages though. Maybe when
> the list of CCs gets broken into multiple lines? That would be a
> git-send-email or MUA problem then though.

The Cc: addresses were added one per line.
For the record, here's the head of the file that caused the trouble
(it was one of the 22 arguments to git-send-email):

  From 999cf5c62ec798b0698970a0bad05b578e3bee3c Mon Sep 17 00:00:00 2001
  From: Jim Meyering <meyering@redhat.com>
  Date: Mon, 7 May 2012 17:06:18 +0200
  Cc: Alexander Graf <agraf@suse.de>
  Cc: Avi Kivity <avi@redhat.com>
  Cc: Marcelo Tosatti <mtosatti@redhat.com>
  Cc: qemu-ppc@nongnu.org (open list:PowerPC)
  Cc: kvm@vger.kernel.org (open list:Overall)

Here's the command I invoked on a debian-unstable system using
git 1.7.10 and postfix as the MTA:

  git send-email --compose --suppress-from \
    --from='Jim Meyering <jim@meyering.net>' --to=qemu-devel@nongnu.org 00*