From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:57506)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1SSBkh-0001eY-Im
	for qemu-devel@nongnu.org; Wed, 09 May 2012 14:36:44 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1SSBkb-0004ye-Ep
	for qemu-devel@nongnu.org; Wed, 09 May 2012 14:36:43 -0400
Received: from cantor2.suse.de ([195.135.220.15]:41996 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1SSBkb-0004yT-8k
	for qemu-devel@nongnu.org; Wed, 09 May 2012 14:36:37 -0400
Message-ID: <4FAAB932.1050604@suse.de>
Date: Wed, 09 May 2012 20:36:34 +0200
From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1336318514-30906-1-git-send-email-afaerber@suse.de>
	<1336318514-30906-42-git-send-email-afaerber@suse.de>
	<201205092013.31233.michael@walle.cc>
In-Reply-To: <201205092013.31233.michael@walle.cc>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH for-next 41/74] target-lm32: Let
 cpu_lm32_init() return LM32CPU
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Michael Walle <michael@walle.cc>
Cc: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org, Anthony Liguori <anthony@codemonkey.ws>, Peter Maydell <peter.maydell@linaro.org>

Am 09.05.2012 20:13, schrieb Michael Walle:
>> Make the include paths for cpu-qom.h consistent to allow using LM32CPU
>> in cpu.h.
>>
>> Let cpu_init() return CPULM32State for backwards compatibility.
>>
>> Signed-off-by: Andreas F=C3=A4rber <afaerber@suse.de>
>=20
> [..]
>=20
> Acked-by: Michael Walle <michael@walle.cc>

Thanks. Needs a respin though: Peter has noticed that cpu_init() does a
NULL pointer deference when cpu_xxx_init() returns NULL. I'm rewriting
as static inline function.

Andreas

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC=
rnberg