From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:38464)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jan.kiszka@siemens.com>) id 1SSCY5-0005tW-LP
	for qemu-devel@nongnu.org; Wed, 09 May 2012 15:27:46 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jan.kiszka@siemens.com>) id 1SSCY3-0001gi-Uo
	for qemu-devel@nongnu.org; Wed, 09 May 2012 15:27:45 -0400
Received: from goliath.siemens.de ([192.35.17.28]:15073)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jan.kiszka@siemens.com>) id 1SSCY3-0001gM-Js
	for qemu-devel@nongnu.org; Wed, 09 May 2012 15:27:43 -0400
Message-ID: <4FAAC526.5060406@siemens.com>
Date: Wed, 09 May 2012 16:27:34 -0300
From: Jan Kiszka <jan.kiszka@siemens.com>
MIME-Version: 1.0
References: <4FA2D4C8.7010007@siemens.com>
	<alpine.LNX.2.00.1205032332230.3296@linmac>
	<4FA2E46B.4070609@siemens.com>
	<alpine.LNX.2.00.1205040350530.4470@linmac>
In-Reply-To: <alpine.LNX.2.00.1205040350530.4470@linmac>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 1.1] audio: Always call fini on exit
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: malc <av1474@comtv.ru>
Cc: qemu-devel <qemu-devel@nongnu.org>

On 2012-05-03 20:51, malc wrote:
> On Thu, 3 May 2012, Jan Kiszka wrote:
> 
>> On 2012-05-03 16:32, malc wrote:
>>> On Thu, 3 May 2012, Jan Kiszka wrote:
>>>
>>>> Not only clean up enabled voices but any registered one. Backends like
>>>> pulsaudio rely on unconditional fini handler invocations.
>>>>
>>>> This fixes "Memory pool destroyed but not all memory blocks freed!"
>>>> warnings on VM shutdowns when pa is used.
>>>
>>> Perhaps it's better to actually handle VOICE_DISABLE in pa's ctl_[in|out]?
>>
>> This might be some additional issue (that pa is not supporting
>> enable/disable). In any case, it is unrelated to this one: fini
>> corresponds to init. And as we initialized the voice, we also have to
>> finalize it on shutdown. That's what this patch is fixing.
>>
> 
> The issue is that i don't remember exactly why it iterates only over
> enabled voices, maybe there was a reason, maybe there wasn't, need to
> think it over. 

Any news on this?

Jan

-- 
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux