From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:59548)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1SSE4e-00084I-3P
	for qemu-devel@nongnu.org; Wed, 09 May 2012 17:05:29 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1SSE4c-000313-9l
	for qemu-devel@nongnu.org; Wed, 09 May 2012 17:05:27 -0400
Received: from cantor2.suse.de ([195.135.220.15]:53817 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1SSE4c-00030s-3X
	for qemu-devel@nongnu.org; Wed, 09 May 2012 17:05:26 -0400
Message-ID: <4FAADC13.4050906@suse.de>
Date: Wed, 09 May 2012 23:05:23 +0200
From: =?ISO-8859-1?Q?Andreas_F=E4rber?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1329189019-13710-1-git-send-email-bo.novell@gmail.com>
	<4FAAD18F.4070604@suse.de>
	<D04CC425-0D99-4D8C-8C08-759F7420CEB0@suse.de>
In-Reply-To: <D04CC425-0D99-4D8C-8C08-759F7420CEB0@suse.de>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH] RTL8139 hotplug is broken on windows 2008
 sp2.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alexander Graf <agraf@suse.de>, Bo Yang <boyang@suse.com>
Cc: Mark McLoughlin <markmc@redhat.com>, qemu-devel@nongnu.org, Anthony Liguori <anthony@codemonkey.ws>, Bruce Rogers <brogers@suse.com>

Am 09.05.2012 23:00, schrieb Alexander Graf:
>=20
> On 09.05.2012, at 22:20, Andreas F=E4rber wrote:
>=20
>> Am 14.02.2012 04:10, schrieb bo.novell@gmail.com:
>>> From: Bo Yang <boyang@suse.com>
>>>
>>> Windows 2008 sp2 tries to read mac address from phys
>>> and then write the read value into it. This patch
>>> is a workaround for the issue.
>>>
>>> Signed-off-by: Bo Yang <boyang@suse.com>
>>> ---
>>> hw/rtl8139.c |    2 ++
>>> 1 files changed, 2 insertions(+), 0 deletions(-)
>>
>> Ping! Who feels responsible for reviewing this?
>> It would be a candidate for 1.1 and 0.15.x (BNC#722643).
>>
>> Only issue I see is that the subject could be improved (saying what it
>> does rather than what was broken before, e.g. "rtl8139: Init phys with
>> MAC address").
>=20
> I thought the real bug was that the reset function didn't get called?

That was for the e1000 that I was working on (BNC#722958). I believe Bo
tested the combination of both patches?

Andreas

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe=
rg