From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:38472) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SSF9X-0005E3-7J for qemu-devel@nongnu.org; Wed, 09 May 2012 18:14:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SSF9V-0004Zi-Ib for qemu-devel@nongnu.org; Wed, 09 May 2012 18:14:34 -0400 Received: from thoth.sbs.de ([192.35.17.2]:31270) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SSF9V-0004YO-8x for qemu-devel@nongnu.org; Wed, 09 May 2012 18:14:33 -0400 Message-ID: <4FAAEC41.70608@siemens.com> Date: Wed, 09 May 2012 19:14:25 -0300 From: Jan Kiszka MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] [PATCH 1.1] Switch SIG_IPI to SIGUSR1 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel , Anthony Liguori Cc: Kevin Wolf , Peter Maydell , Michael Tokarev , Avi Kivity Use SIGUSR1 unconditionally as SIG_IPI. First, ucontext coroutines tend to corrupt RT signal masks due to a 32-on-64-bit Linux kernel bug. And, second, there appears to be no advantage in using RT signals for VCPU kicking. Signed-off-by: Jan Kiszka --- As people prefer to stick with ucontext, this replaces the backend switch for i386-linux. Avi, you once committed the RT signal based SIG_IPI version to qemu-kvm. Can you confirm that SIGUSR1 comes with no downside? This is also stable material. main-loop.h | 4 ---- 1 files changed, 0 insertions(+), 4 deletions(-) diff --git a/main-loop.h b/main-loop.h index c06b8bc..dce1cd9 100644 --- a/main-loop.h +++ b/main-loop.h @@ -25,11 +25,7 @@ #ifndef QEMU_MAIN_LOOP_H #define QEMU_MAIN_LOOP_H 1 -#ifdef SIGRTMIN -#define SIG_IPI (SIGRTMIN+4) -#else #define SIG_IPI SIGUSR1 -#endif /** * qemu_init_main_loop: Set up the process so that it can run the main loop. -- 1.7.3.4