From: Kevin Wolf <kwolf@redhat.com>
To: "Andreas Färber" <afaerber@suse.de>
Cc: Blue Swirl <blauwirbel@gmail.com>, Stefan Weil <sw@weilnetz.de>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 2/2] qtest: Add floppy test
Date: Thu, 10 May 2012 09:30:01 +0200 [thread overview]
Message-ID: <4FAB6E79.3050104@redhat.com> (raw)
In-Reply-To: <4FAAA54B.3060904@suse.de>
Am 09.05.2012 19:11, schrieb Andreas Färber:
> Am 08.05.2012 17:51, schrieb Kevin Wolf:
>> Let's start with testing media change.
>>
>> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
>> ---
>> tests/Makefile | 2 +
>> tests/fdc-test.c | 186 ++++++++++++++++++++++++++++++++++++++++++++++++++++++
>> 2 files changed, 188 insertions(+), 0 deletions(-)
>> create mode 100644 tests/fdc-test.c
>>
>> diff --git a/tests/Makefile b/tests/Makefile
>> index 9988681..a7697bd 100644
>> --- a/tests/Makefile
>> +++ b/tests/Makefile
>> @@ -19,6 +19,7 @@ check-block-$(CONFIG_POSIX) += tests/qemu-iotests-quick.sh
>> # All QTests for now are POSIX-only, but the dependencies are
>> # really in libqtest, not in the testcases themselves.
>> check-qtest-i386-y = tests/rtc-test
>> +check-qtest-i386-y = tests/fdc-test
>
> $(EXESUF)?
>
>> check-qtest-x86_64-y = $(check-qtest-i386-y)
>> check-qtest-sparc-y = tests/m48t59-test$(EXESUF)
>> check-qtest-sparc64-y = tests/m48t59-test$(EXESUF)
>
> Or are these wrong?
I think we should add $(EXESUF) indeed. I copied the rtc-test line where
it's missing as well, so I'll send a patch on top that fixes both.
Kevin
next prev parent reply other threads:[~2012-05-10 7:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-08 15:51 [Qemu-devel] [PATCH 0/2] qtest: Add floppy media change test Kevin Wolf
2012-05-08 15:51 ` [Qemu-devel] [PATCH 1/2] qtest: Add function to send QMP commands Kevin Wolf
2012-05-08 15:51 ` [Qemu-devel] [PATCH 2/2] qtest: Add floppy test Kevin Wolf
2012-05-09 17:11 ` Andreas Färber
2012-05-10 7:30 ` Kevin Wolf [this message]
2012-05-10 7:31 ` Paolo Bonzini
2012-05-10 7:31 ` [Qemu-devel] [PATCH 0/2] qtest: Add floppy media change test Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FAB6E79.3050104@redhat.com \
--to=kwolf@redhat.com \
--cc=afaerber@suse.de \
--cc=blauwirbel@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).