From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:50792)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1SSNpA-00033u-LH
	for qemu-devel@nongnu.org; Thu, 10 May 2012 03:30:10 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1SSNp8-0005C3-Sz
	for qemu-devel@nongnu.org; Thu, 10 May 2012 03:30:08 -0400
Received: from mx1.redhat.com ([209.132.183.28]:13315)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1SSNp8-00059M-Lo
	for qemu-devel@nongnu.org; Thu, 10 May 2012 03:30:06 -0400
Message-ID: <4FAB6E79.3050104@redhat.com>
Date: Thu, 10 May 2012 09:30:01 +0200
From: Kevin Wolf <kwolf@redhat.com>
MIME-Version: 1.0
References: <1336492304-26256-1-git-send-email-kwolf@redhat.com>
	<1336492304-26256-3-git-send-email-kwolf@redhat.com>
	<4FAAA54B.3060904@suse.de>
In-Reply-To: <4FAAA54B.3060904@suse.de>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH 2/2] qtest: Add floppy test
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?ISO-8859-15?Q?Andreas_F=E4rber?= <afaerber@suse.de>
Cc: Blue Swirl <blauwirbel@gmail.com>, Stefan Weil <sw@weilnetz.de>, qemu-devel@nongnu.org

Am 09.05.2012 19:11, schrieb Andreas F=E4rber:
> Am 08.05.2012 17:51, schrieb Kevin Wolf:
>> Let's start with testing media change.
>>
>> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
>> ---
>>  tests/Makefile   |    2 +
>>  tests/fdc-test.c |  186 +++++++++++++++++++++++++++++++++++++++++++++=
+++++++++
>>  2 files changed, 188 insertions(+), 0 deletions(-)
>>  create mode 100644 tests/fdc-test.c
>>
>> diff --git a/tests/Makefile b/tests/Makefile
>> index 9988681..a7697bd 100644
>> --- a/tests/Makefile
>> +++ b/tests/Makefile
>> @@ -19,6 +19,7 @@ check-block-$(CONFIG_POSIX) +=3D tests/qemu-iotests-=
quick.sh
>>  # All QTests for now are POSIX-only, but the dependencies are
>>  # really in libqtest, not in the testcases themselves.
>>  check-qtest-i386-y =3D tests/rtc-test
>> +check-qtest-i386-y =3D tests/fdc-test
>=20
> $(EXESUF)?
>=20
>>  check-qtest-x86_64-y =3D $(check-qtest-i386-y)
>>  check-qtest-sparc-y =3D tests/m48t59-test$(EXESUF)
>>  check-qtest-sparc64-y =3D tests/m48t59-test$(EXESUF)
>=20
> Or are these wrong?

I think we should add $(EXESUF) indeed. I copied the rtc-test line where
it's missing as well, so I'll send a patch on top that fixes both.

Kevin