From: Avi Kivity <avi@redhat.com>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
Peter Maydell <peter.maydell@linaro.org>,
Anthony Liguori <aliguori@us.ibm.com>,
Michael Tokarev <mjt@tls.msk.ru>,
qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH 1.1] Switch SIG_IPI to SIGUSR1
Date: Thu, 10 May 2012 12:35:26 +0300 [thread overview]
Message-ID: <4FAB8BDE.1080709@redhat.com> (raw)
In-Reply-To: <4FAAEC41.70608@siemens.com>
On 05/10/2012 01:14 AM, Jan Kiszka wrote:
> Use SIGUSR1 unconditionally as SIG_IPI. First, ucontext coroutines tend
> to corrupt RT signal masks due to a 32-on-64-bit Linux kernel bug. And,
> second, there appears to be no advantage in using RT signals for VCPU
> kicking.
>
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
>
> As people prefer to stick with ucontext, this replaces the backend
> switch for i386-linux.
>
> Avi, you once committed the RT signal based SIG_IPI version to
> qemu-kvm. Can you confirm that SIGUSR1 comes with no downside?
>
In fact SIGUSR1 would be better in that real-time signals are queued, so
two IPIs are delivered twice with the old SIG_IPI and only once with
SIGUSR1.
I have some vague recollection that real time signals are handled faster
in the kernel. Even if this is true, it's meaningless with kernel
irqchip since signalling is only used heavily with userspace APIC.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2012-05-10 9:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-09 22:14 [Qemu-devel] [PATCH 1.1] Switch SIG_IPI to SIGUSR1 Jan Kiszka
2012-05-09 22:36 ` Andreas Färber
2012-05-10 9:35 ` Avi Kivity [this message]
2012-05-14 15:04 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FAB8BDE.1080709@redhat.com \
--to=avi@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=jan.kiszka@siemens.com \
--cc=kwolf@redhat.com \
--cc=mjt@tls.msk.ru \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).