From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:38373) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SSWY4-0002p9-Uw for qemu-devel@nongnu.org; Thu, 10 May 2012 12:49:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SSWY3-0003YR-1M for qemu-devel@nongnu.org; Thu, 10 May 2012 12:49:04 -0400 Received: from mail-qc0-f173.google.com ([209.85.216.173]:48209) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SSWOm-0007jd-Kg for qemu-devel@nongnu.org; Thu, 10 May 2012 12:39:29 -0400 Received: by qcsc20 with SMTP id c20so1450872qcs.4 for ; Thu, 10 May 2012 09:39:25 -0700 (PDT) Message-ID: <4FABED77.1060808@gmail.com> Date: Fri, 11 May 2012 00:31:51 +0800 From: Bo Yang MIME-Version: 1.0 References: <1329189019-13710-1-git-send-email-bo.novell@gmail.com> <4FAAD18F.4070604@suse.de> <4FAADC13.4050906@suse.de> <5AE33261-DEB3-4F7B-96B3-C51D925B2C8A@suse.de> In-Reply-To: <5AE33261-DEB3-4F7B-96B3-C51D925B2C8A@suse.de> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH] RTL8139 hotplug is broken on windows 2008 sp2. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf Cc: Mark McLoughlin , Bruce Rogers , afaerber@suse.de, Anthony Liguori , qemu-devel@nongnu.org On 05/10/2012 05:06 AM, Alexander Graf wrote: > > On 09.05.2012, at 23:05, Andreas Färber wrote: > >> Am 09.05.2012 23:00, schrieb Alexander Graf: >>> >>> On 09.05.2012, at 22:20, Andreas Färber wrote: >>> >>>> Am 14.02.2012 04:10, schrieb bo.novell@gmail.com: >>>>> From: Bo Yang >>>>> >>>>> Windows 2008 sp2 tries to read mac address from phys >>>>> and then write the read value into it. This patch >>>>> is a workaround for the issue. >>>>> >>>>> Signed-off-by: Bo Yang >>>>> --- >>>>> hw/rtl8139.c | 2 ++ >>>>> 1 files changed, 2 insertions(+), 0 deletions(-) >>>> >>>> Ping! Who feels responsible for reviewing this? >>>> It would be a candidate for 1.1 and 0.15.x (BNC#722643). >>>> >>>> Only issue I see is that the subject could be improved (saying what it >>>> does rather than what was broken before, e.g. "rtl8139: Init phys with >>>> MAC address"). >>> >>> I thought the real bug was that the reset function didn't get called? >> >> That was for the e1000 that I was working on (BNC#722958). I believe Bo >> tested the combination of both patches? > > IIRC the bug was the same, just that you found the root cause and Bo came up with this patch :). yes. > > > Alex >