From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:53408) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SSWZt-0004U9-L3 for qemu-devel@nongnu.org; Thu, 10 May 2012 12:51:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SSWZl-0004Zi-Sj for qemu-devel@nongnu.org; Thu, 10 May 2012 12:50:57 -0400 Received: from mail-pz0-f45.google.com ([209.85.210.45]:38196) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SSWZl-0004XJ-JE for qemu-devel@nongnu.org; Thu, 10 May 2012 12:50:49 -0400 Received: by dadv2 with SMTP id v2so2627257dad.4 for ; Thu, 10 May 2012 09:50:46 -0700 (PDT) Message-ID: <4FABF1DD.7090101@gmail.com> Date: Fri, 11 May 2012 00:50:37 +0800 From: Jiang Liu MIME-Version: 1.0 References: <20111214010645.GA2044@morn.localdomain> <20120509072452.14872.92530.stgit@t> <1336571221.12477.136.camel@bling.home> In-Reply-To: <1336571221.12477.136.camel@bling.home> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RESEND PATCH v3] hotplug: add device per func in ACPI DSDT tables List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alex Williamson Cc: mst@redhat.com, linux-pci@vger.kernel.org, seabios@seabios.org, qemu-devel@nongnu.org, jbarnes@virtuousgeek.org, rjw@sisk.pl, kevin@koconnor.net, Amos Kong On 05/09/2012 09:47 PM, Alex Williamson wrote: >> --- >> src/ssdt-pcihp.dsl | 17 >> src/ssdt-pcihp.hex | 8869 +++++++++++++++++++++++++++++++++++++++++++++++++++- >> 2 files changed, 8781 insertions(+), 105 deletions(-) >> >> diff --git a/src/ssdt-pcihp.dsl b/src/ssdt-pcihp.dsl >> index 4b435b8..2a3c326 100644 >> --- a/src/ssdt-pcihp.dsl >> +++ b/src/ssdt-pcihp.dsl >> @@ -17,14 +17,23 @@ DefinitionBlock ("ssdt-pcihp.aml", "SSDT", 0x01, "BXPC", "BXSSDTPCIHP", 0x1) >> // at runtime, if the slot is detected to not support hotplug. >> // Extract the offset of the address dword and the >> // _EJ0 name to allow this patching. >> -#define hotplug_slot(slot) \ >> - Device (S##slot) { \ >> +#define hotplug_func(slot, fn) \ >> + Device (S##slot##fn) { \ >> ACPI_EXTRACT_NAME_DWORD_CONST aml_adr_dword \ >> - Name (_ADR, 0x##slot##0000) \ > > I would have guessed it to be sufficient to change _ADR to > 0x##slot##ffff, does that not work? Thanks, > > Alex Currently Linux acpiphp driver doesn't support that yet. --gerry