From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:48308) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SSfYE-0007jU-4B for qemu-devel@nongnu.org; Thu, 10 May 2012 22:25:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SSfYB-0002T7-KR for qemu-devel@nongnu.org; Thu, 10 May 2012 22:25:49 -0400 Received: from cantor2.suse.de ([195.135.220.15]:53051 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SSfYB-0002Sw-9T for qemu-devel@nongnu.org; Thu, 10 May 2012 22:25:47 -0400 Message-ID: <4FAC78A2.7010509@suse.de> Date: Fri, 11 May 2012 04:25:38 +0200 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1335958273-769-1-git-send-email-pbonzini@redhat.com> <1335958273-769-3-git-send-email-pbonzini@redhat.com> <4FA126E6.5030508@suse.de> In-Reply-To: <4FA126E6.5030508@suse.de> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 02/21] qom: add object_class_get_parent List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: peter.maydell@linaro.org, aliguori@us.ibm.com, qemu-devel@nongnu.org, liwp@linux.vnet.ibm.com Am 02.05.2012 14:21, schrieb Andreas F=E4rber: > Am 02.05.2012 13:30, schrieb Paolo Bonzini: >> This simple bit of functionality was missing and we'll need it soon, >> so add it. >> >> Signed-off-by: Paolo Bonzini >> --- >> include/qemu/object.h | 8 ++++++++ >> qom/object.c | 13 +++++++++++++ >> 2 files changed, 21 insertions(+) >> >> diff --git a/include/qemu/object.h b/include/qemu/object.h >> index d315dfa..063c817 100644 >> --- a/include/qemu/object.h >> +++ b/include/qemu/object.h >> @@ -548,6 +548,14 @@ ObjectClass *object_class_dynamic_cast(ObjectClas= s *klass, >> const char *typename); >> =20 >> /** >> + * object_class_get_parent: >> + * @klass: The class to obtain the parent for. >> + * >> + * Returns: The parent for @klass. >=20 > Here too we should indicate that this may return NULL (rather than > aborting). Other than that looks good. Thanks, applied to qom-next (with extended documentation): http://repo.or.cz/w/qemu/afaerber.git/shortlog/refs/heads/qom-next I added Anthony's Reviewed-by from v1, since v2 only split off documentation on my request. Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg