From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:56902)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1SSnze-0008Uj-JM
	for qemu-devel@nongnu.org; Fri, 11 May 2012 07:26:46 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1SSnzW-0005KZ-UR
	for qemu-devel@nongnu.org; Fri, 11 May 2012 07:26:42 -0400
Message-ID: <4FACF766.7050005@suse.de>
Date: Fri, 11 May 2012 13:26:30 +0200
From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1336608892-30501-1-git-send-email-afaerber@suse.de>
	<1336608892-30501-74-git-send-email-afaerber@suse.de>
	<CAFEAcA9+xQo74rbQ6wPv_JcyMrxDMkKdmGTp_7ZD=mOow_+kqw@mail.gmail.com>
In-Reply-To: <CAFEAcA9+xQo74rbQ6wPv_JcyMrxDMkKdmGTp_7ZD=mOow_+kqw@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH next v2 73/74] linux-user: Use cpu_reset()
 after cpu_init() / cpu_copy()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Blue Swirl <blauwirbel@gmail.com>, Riku Voipio <riku.voipio@iki.fi>, qemu-ppc <qemu-ppc@nongnu.org>, qemu-devel@nongnu.org, Alexander Graf <agraf@suse.de>

Am 11.05.2012 13:22, schrieb Peter Maydell:
> On 10 May 2012 01:14, Andreas F=C3=A4rber <afaerber@suse.de> wrote:
>> Eliminates cpu_state_reset() usage.
>>
>> Signed-off-by: Andreas F=C3=A4rber <afaerber@suse.de>
>> ---
>>  linux-user/main.c    |    2 +-
>>  linux-user/syscall.c |    2 +-
>>  2 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/linux-user/main.c b/linux-user/main.c
>> index 191b750..49108b8 100644
>> --- a/linux-user/main.c
>> +++ b/linux-user/main.c
>> @@ -3405,7 +3405,7 @@ int main(int argc, char **argv, char **envp)
>>         exit(1);
>>     }
>>  #if defined(TARGET_I386) || defined(TARGET_SPARC) || defined(TARGET_P=
PC)
>> -    cpu_state_reset(env);
>> +    cpu_reset(ENV_GET_CPU(env));
>>  #endif
>>
>>     thread_env =3D env;
>> diff --git a/linux-user/syscall.c b/linux-user/syscall.c
>> index 20d2a74..539af3f 100644
>> --- a/linux-user/syscall.c
>> +++ b/linux-user/syscall.c
>> @@ -4262,7 +4262,7 @@ static int do_fork(CPUArchState *env, unsigned i=
nt flags, abi_ulong newsp,
>>         /* we create a new CPU instance. */
>>         new_env =3D cpu_copy(env);
>>  #if defined(TARGET_I386) || defined(TARGET_SPARC) || defined(TARGET_P=
PC)
>> -        cpu_state_reset(new_env);
>> +        cpu_reset(ENV_GET_CPU(new_env));
>>  #endif
>>         /* Init regs that differ from the parent.  */
>>         cpu_clone_regs(new_env, newsp);
>> --
>=20
> Do you have any plans to try to rationalise the handling of reset
> so that we consistently either do or don't reset the cpu here,
> rather than having it done based on a TARGET_* ifdef ?

Igor had an RFC for x86; sparc and ppc reset I haven't looked into yet.
Cc'ing Alex and Blue.

Andreas

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC=
rnberg