From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:44414) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SSo6A-0005ko-54 for qemu-devel@nongnu.org; Fri, 11 May 2012 07:33:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SSo68-0007BI-8T for qemu-devel@nongnu.org; Fri, 11 May 2012 07:33:25 -0400 Message-ID: <4FACF8FD.4000909@suse.de> Date: Fri, 11 May 2012 13:33:17 +0200 From: =?ISO-8859-1?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1336608892-30501-1-git-send-email-afaerber@suse.de> <1336608892-30501-74-git-send-email-afaerber@suse.de> <4FACF766.7050005@suse.de> <6B65039A-DEDC-404B-9737-09B2CA5CEF87@suse.de> In-Reply-To: <6B65039A-DEDC-404B-9737-09B2CA5CEF87@suse.de> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH next v2 73/74] linux-user: Use cpu_reset() after cpu_init() / cpu_copy() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf Cc: Blue Swirl , Peter Maydell , Riku Voipio , qemu-ppc , qemu-devel@nongnu.org Am 11.05.2012 13:28, schrieb Alexander Graf: >=20 > On 11.05.2012, at 13:26, Andreas F=E4rber wrote: >=20 >> Am 11.05.2012 13:22, schrieb Peter Maydell: >>> On 10 May 2012 01:14, Andreas F=E4rber wrote: >>>> diff --git a/linux-user/syscall.c b/linux-user/syscall.c >>>> index 20d2a74..539af3f 100644 >>>> --- a/linux-user/syscall.c >>>> +++ b/linux-user/syscall.c >>>> @@ -4262,7 +4262,7 @@ static int do_fork(CPUArchState *env, unsigned= int flags, abi_ulong newsp, >>>> /* we create a new CPU instance. */ >>>> new_env =3D cpu_copy(env); >>>> #if defined(TARGET_I386) || defined(TARGET_SPARC) || defined(TARGET_= PPC) >>>> - cpu_state_reset(new_env); >>>> + cpu_reset(ENV_GET_CPU(new_env)); >>>> #endif >>>> /* Init regs that differ from the parent. */ >>>> cpu_clone_regs(new_env, newsp); >>>> -- >>> >>> Do you have any plans to try to rationalise the handling of reset >>> so that we consistently either do or don't reset the cpu here, >>> rather than having it done based on a TARGET_* ifdef ? >> >> Igor had an RFC for x86; sparc and ppc reset I haven't looked into yet= . >> Cc'ing Alex and Blue. >=20 > Why would you ever not want to reset the CPU for a new thread? cpu_copy() -> cpu_init() do so themselves for some architectures. Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg