qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Eric Blake <eblake@redhat.com>
To: Amos Kong <akong@redhat.com>
Cc: aliguori@us.ibm.com, quintela@redhat.com,
	"libvir-list@redhat.com" <libvir-list@redhat.com>,
	jasowang@redhat.com, qemu-devel@nongnu.org,
	Michael Roth <mdroth@linux.vnet.ibm.com>,
	owasserm@redhat.com
Subject: Re: [Qemu-devel] [PATCH v12 0/4] support to migrate with IPv6 address
Date: Fri, 11 May 2012 06:46:16 -0600	[thread overview]
Message-ID: <4FAD0A18.9040207@redhat.com> (raw)
In-Reply-To: <4FACB5AB.5030205@redhat.com>

[-- Attachment #1: Type: text/plain, Size: 1530 bytes --]

[adding libvirt]

On 05/11/2012 12:46 AM, Amos Kong wrote:
> On 05/11/2012 02:12 AM, Michael Roth wrote:
>> On Thu, May 10, 2012 at 11:29:48AM -0600, Eric Blake wrote:
>>> On 05/10/2012 10:27 AM, Amos Kong wrote:
>>>> Those patches updated help functions in qemu-socket.c,
>>>> and used them in migrate-tcp.c to supporting IPv6 migration.

>> addr parsing now relies on qemu-sockets.c:inet_parse(), which has supported
>> [ip6addr]:port for a while, as opposed to net.c:parse_host_port(), which
>> didn't.
> 
> yeah.
> 
> I didn't change qemu monitor cmd interface in this patchset,
> and the transport of data is done by qemu, not libvirt.
> 
> I guess libvirt only needs to update addr string parse,
> for example:
> 
> ---- GOOD
> start a VM:
> # qemu-kvm --enable-kvm -boot n -incoming tcp:ipv6alias:16514 -vnc :1
> -monitor stdio -name qemu-vm1
> 
> try to migrate vm by virsh with addr alias
> # virsh migrate libivrt-vm2 tcp:ipv6alias
> (connection can establish)
> 
> --- FAIL
> start a VM:
> # qemu-kvm-apply-my-patches --enable-kvm -boot n -incoming
> tcp:[2002::3:4]:16514 -vnc :1 -monitor stdio -name qemu-vm1
> 
> try to migrate vm by virsh with ipv6 addr:
> # virsh migrate libvirt-vm2 tcp:[2002::3:4]
> error: invalid argument: could not parse connection URI tcp:[2002::3:4]

Thanks for researching that.  Looks like it should be fixed in libvirt
to match, then.

-- 
Eric Blake   eblake@redhat.com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 620 bytes --]

  reply	other threads:[~2012-05-11 12:46 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-10 16:27 [Qemu-devel] [PATCH v12 0/4] support to migrate with IPv6 address Amos Kong
2012-05-10 16:28 ` [Qemu-devel] [PATCH v12 1/4] qerror: add five qerror strings Amos Kong
2012-05-10 17:21   ` Michael Roth
2012-05-10 16:28 ` [Qemu-devel] [PATCH v12 2/4] sockets: change inet_connect() to support nonblock socket Amos Kong
2012-05-10 16:28 ` [Qemu-devel] [PATCH v12 3/4] sockets: use error class to pass listen error Amos Kong
2012-05-10 16:28 ` [Qemu-devel] [PATCH v12 4/4] use inet_listen()/inet_connect() to support ipv6 migration Amos Kong
2012-05-10 17:29 ` [Qemu-devel] [PATCH v12 0/4] support to migrate with IPv6 address Eric Blake
2012-05-10 18:12   ` Michael Roth
2012-05-11  6:46     ` Amos Kong
2012-05-11 12:46       ` Eric Blake [this message]
2012-05-14 15:04 ` Anthony Liguori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FAD0A18.9040207@redhat.com \
    --to=eblake@redhat.com \
    --cc=akong@redhat.com \
    --cc=aliguori@us.ibm.com \
    --cc=jasowang@redhat.com \
    --cc=libvir-list@redhat.com \
    --cc=mdroth@linux.vnet.ibm.com \
    --cc=owasserm@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).