From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:59541) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SSpEu-0002u7-Uu for qemu-devel@nongnu.org; Fri, 11 May 2012 08:46:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SSpEp-0002dY-N9 for qemu-devel@nongnu.org; Fri, 11 May 2012 08:46:32 -0400 Received: from mx1.redhat.com ([209.132.183.28]:14419) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SSpEp-0002dS-EY for qemu-devel@nongnu.org; Fri, 11 May 2012 08:46:27 -0400 Message-ID: <4FAD0A18.9040207@redhat.com> Date: Fri, 11 May 2012 06:46:16 -0600 From: Eric Blake MIME-Version: 1.0 References: <20120510162606.15504.39510.stgit@t> <4FABFB0C.7010801@redhat.com> <20120510181251.GE17353@illuin> <4FACB5AB.5030205@redhat.com> In-Reply-To: <4FACB5AB.5030205@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enigBF0215E8871D836FCDBF834D" Subject: Re: [Qemu-devel] [PATCH v12 0/4] support to migrate with IPv6 address List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Amos Kong Cc: aliguori@us.ibm.com, quintela@redhat.com, "libvir-list@redhat.com" , jasowang@redhat.com, qemu-devel@nongnu.org, Michael Roth , owasserm@redhat.com This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigBF0215E8871D836FCDBF834D Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable [adding libvirt] On 05/11/2012 12:46 AM, Amos Kong wrote: > On 05/11/2012 02:12 AM, Michael Roth wrote: >> On Thu, May 10, 2012 at 11:29:48AM -0600, Eric Blake wrote: >>> On 05/10/2012 10:27 AM, Amos Kong wrote: >>>> Those patches updated help functions in qemu-socket.c, >>>> and used them in migrate-tcp.c to supporting IPv6 migration. >> addr parsing now relies on qemu-sockets.c:inet_parse(), which has supp= orted >> [ip6addr]:port for a while, as opposed to net.c:parse_host_port(), whi= ch >> didn't. >=20 > yeah. >=20 > I didn't change qemu monitor cmd interface in this patchset, > and the transport of data is done by qemu, not libvirt. >=20 > I guess libvirt only needs to update addr string parse, > for example: >=20 > ---- GOOD > start a VM: > # qemu-kvm --enable-kvm -boot n -incoming tcp:ipv6alias:16514 -vnc :1 > -monitor stdio -name qemu-vm1 >=20 > try to migrate vm by virsh with addr alias > # virsh migrate libivrt-vm2 tcp:ipv6alias > (connection can establish) >=20 > --- FAIL > start a VM: > # qemu-kvm-apply-my-patches --enable-kvm -boot n -incoming > tcp:[2002::3:4]:16514 -vnc :1 -monitor stdio -name qemu-vm1 >=20 > try to migrate vm by virsh with ipv6 addr: > # virsh migrate libvirt-vm2 tcp:[2002::3:4] > error: invalid argument: could not parse connection URI tcp:[2002::3:4]= Thanks for researching that. Looks like it should be fixed in libvirt to match, then. --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enigBF0215E8871D836FCDBF834D Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBCAAGBQJPrQoYAAoJEKeha0olJ0Nq1aMIAKIFjBbR0nYBG9FkSveSjn60 lmVtx49QvMLdCpyGbtpZ9HjIncJCccRxOVs9Km+7uKIjOmyqEsfqy9X3sjOKQXLl ZhxXOZC4mrZo4JqP80gzcZxMPTLdDwpTKJonPWvx2YAMi77n+xlZrF7ZHLL6JhPK ANgGEYhTi1x6yBgTg4sYw2xe+xyc9dYxU9gdr1ysCu4waANhOuY8faTtJAy6H+MO Xd9gMf8aMDZM9No9OYzVszM3jJNyi0A52uNAnsZSPSO3uJSGIK29ZqFJ328iBdgO UJj/01OYOqO6R+YtSxKXkutzS0slBpzZeqLokxxRHWmOK/RCmMAT7E3K9iG26VI= =NrzR -----END PGP SIGNATURE----- --------------enigBF0215E8871D836FCDBF834D--