From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:59255) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SSpz8-0003fo-NH for qemu-devel@nongnu.org; Fri, 11 May 2012 09:34:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SSpz6-0004LB-8t for qemu-devel@nongnu.org; Fri, 11 May 2012 09:34:18 -0400 Received: from cantor2.suse.de ([195.135.220.15]:37660 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SSpz6-0004Ku-2j for qemu-devel@nongnu.org; Fri, 11 May 2012 09:34:16 -0400 Message-ID: <4FAD1553.6010203@suse.de> Date: Fri, 11 May 2012 15:34:11 +0200 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= MIME-Version: 1.0 References: <1336608892-30501-1-git-send-email-afaerber@suse.de> <1336608892-30501-36-git-send-email-afaerber@suse.de> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH next v2 35/74] armv7m: Use cpu_arm_init() to obtain ARMCPU List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: qemu-devel@nongnu.org Am 11.05.2012 13:18, schrieb Peter Maydell: > On 10 May 2012 01:14, Andreas F=C3=A4rber wrote: >> Needed for armv7m_reset(). >> >> Signed-off-by: Andreas F=C3=A4rber >=20 > Acked-by: Peter Maydell Thanks, applied to qom-next: http://repo.or.cz/w/qemu/afaerber.git/shortlog/refs/heads/qom-next > I'd have preferred it if you hadn't made the style change > from "if (!foo)" to "if (foo =3D=3D NULL)", incidentally, but I'm > not going to insist on a respin for it. For the record, Peter's request here was to not propagate such stylistic changes unneccessarily throughout old code. In these two cases on one line I added the missing opening brace and on the other I had to change the variable name so it does not add to the patch. Both styles are valid C and can be expected to produce identical machine code with an optimizing compiler. What we might do though is assist the compiler in determining which code paths are likely() vs. unlikely(). For stylistic reasons I prefer to have the unlikely error case in the if, e.g. in cpu_sh4_init(). These are not hot paths though so it shouldn't matter much. /-F --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC= rnberg