From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:36420) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SSqYO-0005Uc-A4 for qemu-devel@nongnu.org; Fri, 11 May 2012 10:10:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SSqYM-0004Nf-IW for qemu-devel@nongnu.org; Fri, 11 May 2012 10:10:43 -0400 Received: from cantor2.suse.de ([195.135.220.15]:40049 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SSqYM-0004NV-4W for qemu-devel@nongnu.org; Fri, 11 May 2012 10:10:42 -0400 Message-ID: <4FAD1DDA.80609@suse.de> Date: Fri, 11 May 2012 16:10:34 +0200 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1333451753-3550-1-git-send-email-pbonzini@redhat.com> <1333451753-3550-8-git-send-email-pbonzini@redhat.com> <4F7AECF5.3020402@siemens.com> <4F7AF5A9.1070209@redhat.com> In-Reply-To: <4F7AF5A9.1070209@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 07/25] qdev: use object_property_print in info qtree List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: Jan Kiszka , aliguori@us.ibm.com, qemu-devel@nongnu.org Am 03.04.2012 15:05, schrieb Paolo Bonzini: > Il 03/04/2012 14:28, Jan Kiszka ha scritto: >>>> if (object_property_get_type(OBJECT(dev), legacy_name, NULL= )) { >>>> value =3D object_property_get_str(OBJECT(dev), legacy_n= ame, &err); >> This is not a criticism on this patch, but I'd like to underline that >> the line above only works because legacy props also define print > ^^^^ >=20 > You mean always, I guess. >=20 >> But this statement above is still inconsistent. We should either >> assert(print && parse) or handle their non-existence properly. >=20 > Yes, asserting that print/parse are always present in pairs (if at all) > would be good. Paolo, has this issue been addressed somewhere? Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg