From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:35932) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SSqiS-0000Mj-Jt for qemu-devel@nongnu.org; Fri, 11 May 2012 10:21:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SSqiL-0006ys-Jm for qemu-devel@nongnu.org; Fri, 11 May 2012 10:21:08 -0400 Received: from cantor2.suse.de ([195.135.220.15]:40761 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SSqiL-0006yi-AS for qemu-devel@nongnu.org; Fri, 11 May 2012 10:21:01 -0400 Message-ID: <4FAD2048.80606@suse.de> Date: Fri, 11 May 2012 16:20:56 +0200 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1335958273-769-1-git-send-email-pbonzini@redhat.com> <1335958273-769-9-git-send-email-pbonzini@redhat.com> In-Reply-To: <1335958273-769-9-git-send-email-pbonzini@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 08/21] qdev: use object_property_print in info qtree List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: peter.maydell@linaro.org, aliguori@us.ibm.com, qemu-devel@nongnu.org, liwp@linux.vnet.ibm.com Am 02.05.2012 13:31, schrieb Paolo Bonzini: > Otherwise, non-string properties without a legacy counterpart are misse= d. > Also fix error propagation in object_property_print itself. >=20 > Signed-off-by: Paolo Bonzini > --- > hw/qdev-monitor.c | 2 +- > qom/object.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/hw/qdev-monitor.c b/hw/qdev-monitor.c > index 41b9e2c..eed781d 100644 > --- a/hw/qdev-monitor.c > +++ b/hw/qdev-monitor.c > @@ -493,7 +493,7 @@ static void qdev_print_props(Monitor *mon, DeviceSt= ate *dev, Property *props, > if (object_property_get_type(OBJECT(dev), legacy_name, NULL)) = { > value =3D object_property_get_str(OBJECT(dev), legacy_name= , &err); > } else { > - value =3D object_property_get_str(OBJECT(dev), props->name= , &err); > + value =3D object_property_print(OBJECT(dev), props->name, = &err); > } > g_free(legacy_name); > =20 > diff --git a/qom/object.c b/qom/object.c > index 464fc8f..b4f6c1d 100644 > --- a/qom/object.c > +++ b/qom/object.c > @@ -839,7 +839,7 @@ char *object_property_print(Object *obj, const char= *name, > char *string; char *string =3D NULL; > =20 > mo =3D string_output_visitor_new(); > - object_property_get(obj, string_output_get_visitor(mo), name, NULL= ); > + object_property_get(obj, string_output_get_visitor(mo), name, errp= ); If we do error checking we should be consequent and do: if (!error_is_set(errp)) { > string =3D string_output_get_string(mo); } > string_output_visitor_cleanup(mo); > return string; Otherwise looks good and a 1.1 candidate. /-F --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg