Re: [Qemu-devel] [PATCH v2 02/24] qom: add object_child_foreach

Re: [Qemu-devel] [PATCH v2 02/24] qom: add object_child_foreach

[Andreas Färber]

Am 12.04.2012 18:03, schrieb Andreas Färber:
> Am 11.04.2012 23:30, schrieb Paolo Bonzini:
>> A utility function that will be used to implement hierarchical realization.
>>
>> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

Reviewed-by: Anthony Liguori <aliguori@us.ibm.com>

>> ---
>>  include/qemu/object.h |   14 +++++++++++++-
>>  qom/object.c          |   17 +++++++++++++++++
>>  2 files changed, 30 insertions(+), 1 deletion(-)
>>
>> diff --git a/include/qemu/object.h b/include/qemu/object.h
>> index f814521..470efe3 100644
>> --- a/include/qemu/object.h
>> +++ b/include/qemu/object.h
>> @@ -918,6 +918,19 @@ void object_property_add_str(Object *obj, const char *name,
>>                               struct Error **errp);
>>  
>>  /**
>> + * object_child_foreach:
>> + * @obj: the object whose children will be navigated
>> + * @fn: the iterator function to be called
>> + * @opaque: an opaque value that will be passed to the iterator
>> + *
>> + * Call @fn passing each child of @obj and @opaque to it, until @fn returns
>> + * non-zero.  Return the last value returned by @fn, or 0 if there is no
>> + * child.

I've turned the last sentence into a gtk-doc Returns: statement.

>> + */
>> +int object_child_foreach(Object *obj, int (*fn)(Object *child, void *opaque),
>> +                         void *opaque);
>> +
>> +/**
>>   * container_get:
>>   * @path: path to the container
>>   *
>> @@ -928,5 +941,4 @@ void object_property_add_str(Object *obj, const char *name,
>>   */
>>  Object *container_get(const char *path);
>>  
>> -
> 
> Unrelated whitespace change.

Thanks, applied to qom-next (with whitespace change dropped):
http://repo.or.cz/w/qemu/afaerber.git/shortlog/refs/heads/qom-next

/-F

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg